Skip to content

OSASINFRA-3960: Stop running unit tests for CAPO openshift dir #72221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 2 commits into from
Dec 5, 2025
Merged

OSASINFRA-3960: Stop running unit tests for CAPO openshift dir #72221

openshift-merge-bot merged 2 commits into from
Dec 5, 2025

Conversation

@stephenfin
Copy link
Contributor

@stephenfin stephenfin commented Dec 5, 2025

We no longer have code to unit test here and the test Makefile target is just a stub.

@stephenfin
openstack: Stop calling test openshift make target for CAPO
84ce78e 
We no longer have code to unit test in this directory.

Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
@stephenfin
openstack: Simplify commands for CAPO tests
0ef0505 
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 5, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 5, 2025 •
edited by openshift-ci bot
Loading

@stephenfin: This pull request references OSASINFRA-3960 which is a valid jira issue.

Details

In response to this:

We no longer have code to unit test here and the test Makefile target is just a stub.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from gryf and pierreprinetti December 5, 2025 11:00
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2025
mandre
mandre reviewed Dec 5, 2025
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre, stephenfin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 5, 2025

[REHEARSALNOTIFIER]
@stephenfin: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-api-provider-openstack-release-4.22-test openshift/cluster-api-provider-openstack presubmit Ci-operator config changed
pull-ci-openshift-cluster-api-provider-openstack-release-4.22-test-openshift openshift/cluster-api-provider-openstack presubmit Ci-operator config changed
pull-ci-openshift-cluster-api-provider-openstack-release-4.22-verify openshift/cluster-api-provider-openstack presubmit Ci-operator config changed
pull-ci-openshift-cluster-api-provider-openstack-main-test openshift/cluster-api-provider-openstack presubmit Ci-operator config changed
pull-ci-openshift-cluster-api-provider-openstack-main-test-openshift openshift/cluster-api-provider-openstack presubmit Ci-operator config changed
pull-ci-openshift-cluster-api-provider-openstack-main-verify openshift/cluster-api-provider-openstack presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@stephenfin
Copy link
Contributor Author

stephenfin commented Dec 5, 2025

/pj-rehearse
/pj-rehearse auto-ack

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 5, 2025

@stephenfin: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 5, 2025

@stephenfin: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command.

stephenfin added a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Dec 5, 2025
@stephenfin
CARRY: openshift: Remove e2e, test makefile targets
f5d7bd6 
These are remnants of the in-tree infracluster controller and are no
longer used by CI jobs [1][2].

[1] openshift/release#72179
[2] openshift/release#72221

Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
@stephenfin
Copy link
Contributor Author

stephenfin commented Dec 5, 2025

/pj-rehearse auto-ack

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 5, 2025

@stephenfin: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 5, 2025

@stephenfin: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Dec 5, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 5b7dc9e into openshift:master Dec 5, 2025
18 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the capo-remove-test-target branch December 5, 2025 12:18
dfrazzette pushed a commit to dfrazzette/release that referenced this pull request Dec 9, 2025
@stephenfin @dfrazzette
OSASINFRA-3960: Stop running unit tests for CAPO openshift dir (opens…
d74f2b5 
…hift#72221)

* openstack: Stop calling test openshift make target for CAPO

We no longer have code to unit test in this directory.

Signed-off-by: Stephen Finucane <stephenfin@redhat.com>

* openstack: Simplify commands for CAPO tests

Signed-off-by: Stephen Finucane <stephenfin@redhat.com>

---------

Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gryf gryf Awaiting requested review from gryf

@pierreprinetti pierreprinetti Awaiting requested review from pierreprinetti

1 more reviewer

@mandre mandre mandre left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@mandre mandre

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stephenfin @openshift-ci-robot @mandre