-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Fix debug-winc jobs by adding tests-private base image for 4.20-4.23 #73778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix debug-winc jobs by adding tests-private base image for 4.20-4.23 #73778
Conversation
The debug-winc-* rehearsal jobs fail with 'manifest unknown' error when trying to pull the tests-private image from the internal registry. This fix adds tests-private as a base_image (imported from ci namespace) for releases 4.20-4.23 where the config doesn't build this image itself. Versions 4.17-4.19 already build tests-private in their images section, so they don't need this base_image entry. This allows debug-winc jobs to reference stable:tests-private without ImagePullBackOff errors. Fixes: openshift#71002 (comment)
|
[REHEARSALNOTIFIER]
A total of 2128 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liangxia, rrasouli, weinliu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/pj-rehearse ack |
|
@rrasouli: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@rrasouli: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
Fixes debug-winc-* rehearsal jobs that fail with
manifest unknownerror when trying to pull thetests-privateimage from the internal registry.Changes
Adds
tests-privateas a base_image (imported fromcinamespace) for OpenShift releases 4.20, 4.21, 4.22, 4.23.Why these versions?
tests-privatein theirimagessection → No change neededError Fixed
Before:
After:
Testing
This fix was previously merged in PR #71432 but was reverted by
config-brancher. This PR re-applies it with proper scope (4.20-4.23 only).Related