Skip to content

Conversation

@nalind
Copy link
Member

@nalind nalind commented Jan 28, 2026

Run our unit tests with a not-archived-yet version of Go. Version 1.26 is imminent, but for now, 1.23 is what we're about to start using when running conformance tests.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2026
@nalind
Copy link
Member Author

nalind commented Jan 28, 2026

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@nalind: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Run our unit tests with a slightly newer but still not current version
of Go.  Version 1.26 is imminent, but for now, 1.23 is what we're about
to start using when running conformance tests.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
@nalind nalind force-pushed the imagebuilder-with-go-1.24 branch from 91999b8 to eaf2dfe Compare January 29, 2026 19:03
@nalind
Copy link
Member Author

nalind commented Jan 29, 2026

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@nalind: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@nalind: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-imagebuilder-master-unit openshift/imagebuilder presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 29, 2026

@nalind: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@nalind nalind changed the title imagebuilder: run unit tests with Go 1.24 instead of 1.21 imagebuilder: run unit tests with Go 1.23 instead of 1.21 Jan 29, 2026
@jlebon
Copy link
Member

jlebon commented Jan 29, 2026

I don't think my vote counts, but this looks sane to me!
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2026
@jlebon
Copy link
Member

jlebon commented Jan 29, 2026

You'll also need to /pj-rehearse ack if you're done rehearsing tests.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 29, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlebon, nalind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nalind
Copy link
Member Author

nalind commented Jan 29, 2026

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@nalind: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jan 29, 2026
@TomSweeneyRedHat
Copy link

LGTM

@openshift-merge-bot openshift-merge-bot bot merged commit b699712 into openshift:master Jan 29, 2026
14 checks passed
@nalind nalind deleted the imagebuilder-with-go-1.24 branch January 29, 2026 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants