-
Notifications
You must be signed in to change notification settings - Fork 2.1k
imagebuilder: run unit tests with Go 1.23 instead of 1.21 #74094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
imagebuilder: run unit tests with Go 1.23 instead of 1.21 #74094
Conversation
|
/pj-rehearse |
|
@nalind: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Run our unit tests with a slightly newer but still not current version of Go. Version 1.26 is imminent, but for now, 1.23 is what we're about to start using when running conformance tests. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
91999b8 to
eaf2dfe
Compare
|
/pj-rehearse |
|
@nalind: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@nalind: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
I don't think my vote counts, but this looks sane to me! |
|
You'll also need to |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlebon, nalind The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/pj-rehearse ack |
|
@nalind: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
LGTM |
Run our unit tests with a not-archived-yet version of Go. Version 1.26 is imminent, but for now, 1.23 is what we're about to start using when running conformance tests.