OADP: migrate CI from deprecated OO_INDEX to OO_BUNDLE (FBC)#79152
OADP: migrate CI from deprecated OO_INDEX to OO_BUNDLE (FBC)#79152kaovilai wants to merge 5 commits into
Conversation
Migrate all 15 oadp-operator variant CI configs from the deprecated index image path to the recommended operator-sdk bundle workflow. Changes per config: - operator.bundles: add `as: oadp-operator-bundle` + `skip_building_index: true` - dependencies: OO_INDEX: ci-index → OO_BUNDLE: oadp-operator-bundle - workflow: optional-operators-ci-aws → optional-operators-ci-operator-sdk-aws - env: replace OO_CHANNEL/OO_PACKAGE/OO_TARGET_NAMESPACES with OO_INSTALL_MODE: OwnNamespace The deprecated index image building will be removed from ci-operator soon. See: https://docs.ci.openshift.org/how-tos/testing-operator-sdk-operators/#building-an-index-deprecated Unblocks: openshift/oadp-operator#2160 Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Happy <yesreply@happy.engineering> Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (7)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughMultiple OADP CI YAMLs were updated to build and publish a named bundle ( Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes 🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
openshift-ci
Bot
added
the
approved
|
/pj-rehearse auto-ack |
|
@kaovilai: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-ci
Bot
requested review from
shubham-pampattiwar,
sseago and
weshayutin
There was a problem hiding this comment.
Pull request overview
Migrates the OADP operator variant ci-operator configs from the deprecated index-image-based optional-operators workflow (OO_INDEX / optional-operators-ci-aws) to the operator-sdk bundle workflow (OO_BUNDLE / optional-operators-ci-operator-sdk-aws) to avoid upcoming ci-operator index build removal.
Changes:
- Define a named operator bundle (
as: oadp-operator-bundle) and setskip_building_index: truein each variant config. - Switch test dependencies from
OO_INDEX: ci-indextoOO_BUNDLE: oadp-operator-bundle. - Update workflows to
optional-operators-ci-operator-sdk-awsand replace channel/package/target namespace env withOO_INSTALL_MODE: OwnNamespace.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ci-operator/config/openshift/oadp-operator/openshift-oadp-operator-oadp-dev__5.0.yaml | Switch OADP dev 5.0 CI to operator-sdk bundle workflow and bundle dependency. |
| ci-operator/config/openshift/oadp-operator/openshift-oadp-operator-oadp-dev__4.23.yaml | Switch OADP dev 4.23 CI to operator-sdk bundle workflow and bundle dependency. |
| ci-operator/config/openshift/oadp-operator/openshift-oadp-operator-oadp-dev__4.22.yaml | Switch OADP dev 4.22 CI to operator-sdk bundle workflow and bundle dependency. |
| ci-operator/config/openshift/oadp-operator/openshift-oadp-operator-oadp-1.6__5.0.yaml | Switch OADP 1.6 5.0 CI to operator-sdk bundle workflow and bundle dependency. |
| ci-operator/config/openshift/oadp-operator/openshift-oadp-operator-oadp-1.6__4.22.yaml | Switch OADP 1.6 4.22 CI to operator-sdk bundle workflow and bundle dependency. |
| ci-operator/config/openshift/oadp-operator/openshift-oadp-operator-oadp-1.6__4.18.yaml | Switch OADP 1.6 4.18 CI to operator-sdk bundle workflow and bundle dependency. |
| ci-operator/config/openshift/oadp-operator/openshift-oadp-operator-oadp-1.5__4.20.yaml | Switch OADP 1.5 4.20 CI to operator-sdk bundle workflow and bundle dependency. |
| ci-operator/config/openshift/oadp-operator/openshift-oadp-operator-oadp-1.5__4.19.yaml | Switch OADP 1.5 4.19 CI to operator-sdk bundle workflow and bundle dependency. |
| ci-operator/config/openshift/oadp-operator/openshift-oadp-operator-oadp-1.4__4.18.yaml | Switch OADP 1.4 4.18 CI to operator-sdk bundle workflow and bundle dependency. |
| ci-operator/config/openshift/oadp-operator/openshift-oadp-operator-oadp-1.3__4.15.yaml | Switch OADP 1.3 4.15 CI to operator-sdk bundle workflow and bundle dependency. |
| ci-operator/config/openshift/oadp-operator/openshift-oadp-operator-oadp-1.3__4.14.yaml | Switch OADP 1.3 4.14 CI to operator-sdk bundle workflow and bundle dependency. |
| ci-operator/config/openshift/oadp-operator/openshift-oadp-operator-oadp-1.3__4.13.yaml | Switch OADP 1.3 4.13 CI to operator-sdk bundle workflow and bundle dependency. |
| ci-operator/config/openshift/oadp-operator/openshift-oadp-operator-oadp-1.3__4.12.yaml | Switch OADP 1.3 4.12 CI to operator-sdk bundle workflow and bundle dependency. |
| ci-operator/config/openshift/oadp-operator/openshift-oadp-operator-oadp-1.0__4.14.yaml | Switch OADP 1.0 4.14 CI to operator-sdk bundle workflow and bundle dependency. |
| ci-operator/config/openshift/oadp-operator/openshift-oadp-operator-oadp-1.0__4.12.yaml | Switch OADP 1.0 4.12 CI to operator-sdk bundle workflow and bundle dependency. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kaovilai
changed the title
|
@kaovilai can you just delete any oadp-1.0.x files, we don't need to update them. We only need OADP-1.3+ |
|
its just for sanity.. :/ |
OADP 1.0 is EOL — no need to maintain these CI configs. Only OADP 1.3+ configs are needed going forward. Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Happy <yesreply@happy.engineering> Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
|
nuke a few more old jobs I think iiuc |
prowgen doesn't prune job files when source configs are deleted. Manual cleanup of generated jobs for removed oadp-1.0 variant configs. Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Happy <yesreply@happy.engineering> Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
|
/pj-rehearse auto-ack |
|
@kaovilai: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/retest |
|
/pj-rehearse auto-ack |
|
@kaovilai: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/retest |
Latest prowgen renames ci-index validation jobs to ci-bundle-oadp-operator-bundle when skip_building_index is set. Also restores oadp-1.0 job files which are still needed for the default (non-variant) oadp-1.0 config's unit test jobs. Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Happy <yesreply@happy.engineering> Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
Run sanitize-prow-jobs to add missing cluster: fields (build01, build11) to newly generated ci-bundle-oadp-operator-bundle presubmit jobs. Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Happy <yesreply@happy.engineering> Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
|
[REHEARSALNOTIFIER]
A total of 78 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse auto-ack |
|
@kaovilai: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-oadp-operator-oadp-1.6-4.22-e2e-test-aws |
|
@kaovilai: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-oadp-operator-oadp-1.3-4.12-e2e-test-aws |
|
@kaovilai: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaovilai, shubham-pampattiwar, weshayutin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@kaovilai: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/pj-rehearse pull-ci-openshift-oadp-operator-oadp-1.6-4.22-e2e-test-aws |
|
@weshayutin: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Summary
Migrate all oadp-operator variant CI configs from the deprecated index image path (
OO_INDEX: ci-index+optional-operators-ci-aws) to the recommended operator-sdk bundle workflow (OO_BUNDLE+optional-operators-ci-operator-sdk-aws). Also removes EOL oadp-1.0 variant configs entirely.Changes per config:
operator.bundles: addas: oadp-operator-bundle+skip_building_index: truedependencies:OO_INDEX: ci-index→OO_BUNDLE: oadp-operator-bundleworkflow:optional-operators-ci-aws→optional-operators-ci-operator-sdk-awsenv: replaceOO_CHANNEL/OO_PACKAGE/OO_TARGET_NAMESPACESwithOO_INSTALL_MODE: OwnNamespaceMigrated configs (13 files):
oadp-1.3(4.12, 4.13, 4.14, 4.15)oadp-1.4(4.18)oadp-1.5(4.19, 4.20)oadp-1.6(4.18, 4.22, 5.0)oadp-dev(4.22, 4.23, 5.0)Deleted configs (2 files):
oadp-1.0(4.12, 4.14) — EOL, no longer neededWhy:
Since OCP 4.11+, index images are file-based catalogs (FBC) which are incompatible with ci-operator's legacy index image building. Building index images is deprecated and will be removed from ci-operator. The recommended replacement is
operator-sdk run bundlevia theoptional-operators-ci-operator-sdk-awsworkflow, which works with both legacy and FBC index formats.See also: Moving to File-Based Catalog
Unblocks: openshift/oadp-operator#2160
Note
Responses generated with Claude