vsphere upi: updates for terraform changes

[jcpowermac]

• Added new terraform variables required in the recent
  changes in vsphere upi terraform

• Added an additional run of the registry patch
  in some instances the config is not update properly.

• vim - autocmd BufWritePre * %s/\s\+$//e removed white space

[jcpowermac]

This PR can be merged without the changes to the installer:
openshift/installer#3429

[abhinavdahiya]

can you separate the remove extra space commit from code changes please.

[abhinavdahiya]

Added an additional run of the registry patch
in some instances the config is not update properly.

can you link to the BZ that explains why this change is required, or provide the details in the commit message. Currently it's unclear.

[bparees]

/approve

will wait for @abhinavdahiya to lgtm

[abhinavdahiya]

Added new terraform variables required in the recent
changes in vsphere upi terraform

this template is used by all releases 4.{1,2,3,4} and master.. so please make sure adding these new variables do not break previous releases.

[jcpowermac]

Added new terraform variables required in the recent
changes in vsphere upi terraform

this template is used by all releases 4.{1,2,3,4} and master.. so please make sure adding these new variables do not break previous releases.

I have extra variables in my terraform.tfvars it just seems to warn that they are there.
updated as asked

[jcpowermac]

/test pj-rehearse

[patrickdillon]

LGTM.

[openshift-ci-robot]

@jcpowermac: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/rehearse/openshift/installer/master/e2e-azure-upi	5887615	link	/test pj-rehearse
ci/rehearse/openshift/cluster-image-registry-operator/master/e2e-vsphere	5887615	link	/test pj-rehearse
ci/rehearse/openshift/cluster-version-operator/master/e2e-aws-upi	5887615	link	/test pj-rehearse
ci/prow/pj-rehearse	5887615	link	/test pj-rehearse

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[sdodson]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, jcpowermac, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/templates/openshift/installer/OWNERS [bparees,sdodson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@jcpowermac: Updated the following 2 configmaps:

• prow-job-cluster-launch-installer-upi-e2e configmap in namespace ci at cluster api.ci using the following files:
  • key cluster-launch-installer-upi-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-upi-e2e.yaml
• prow-job-cluster-launch-installer-upi-e2e configmap in namespace ci at cluster ci/api-build01-ci-devcluster-openshift-com:6443 using the following files:
  • key cluster-launch-installer-upi-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-upi-e2e.yaml

Details

In response to this:

• Added new terraform variables required in the recent
  changes in vsphere upi terraform

• Added an additional run of the registry patch
  in some instances the config is not update properly.

• vim - autocmd BufWritePre * %s/\s\+$//e removed white space

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.