Skip to content

Conversation

@stbenjam
Copy link
Member

No description provided.

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: stbenjam
To complete the pull request process, please assign tnozicka
You can assign the PR to them by writing /assign @tnozicka in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wking
Copy link
Member

wking commented Apr 19, 2020

If you do 4.4 and master, shouldn't you do 4.5 too?

@stbenjam
Copy link
Member Author

If you do 4.4 and master, shouldn't you do 4.5 too?

The last time I tried to add it to 4.5/4.6, DPTP told me a bot automatically does it. I don't know how often it runs but it does seem to happen sometimes: 3b5dca5

@soltysh
Copy link

soltysh commented Apr 20, 2020

The last time I tried to add it to 4.5/4.6, DPTP told me a bot automatically does it. I don't know how often it runs but it does seem to happen sometimes: 3b5dca5

Sometimes doesn't sound convincing, why not just make it there, it definitely doesn't hurt 😉

@stbenjam
Copy link
Member Author

stbenjam commented Apr 20, 2020

It also doesn’t not hurt. I can add it later if the script doesn’t do it. I won’t be around for a few more hours to add it. It’d be nice if we could test the oc PR and unbreak us....

@stbenjam
Copy link
Member Author

stbenjam commented Apr 20, 2020

I guess it doesn't matter since openshift/oc#392 is approved and going to merge. I'll update this PR later when I'm on my computer.

It seems odd to me that oc PR's that affect disconnected installation get merged without a single CI test that does a disconnected install, or does e2e-cmd do that?

@soltysh
Copy link

soltysh commented Apr 20, 2020

It seems odd to me that oc PR's that affect disconnected installation get merged without a single CI test that does a disconnected install, or does e2e-cmd do that?

Nobody added it since there was no clear requirement, yet. e2e-cmd is different, in the long run it will turn to be part of regular e2e.

@openshift-ci-robot
Copy link
Contributor

@stbenjam: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 1, 2020
@openshift-ci-robot
Copy link
Contributor

@stbenjam: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/oc/master/e2e-metal-ipi 226e7ae link /test pj-rehearse
ci/rehearse/openshift/oc/release-4.4/e2e-metal-ipi 226e7ae link /test pj-rehearse
ci/prow/pj-rehearse 226e7ae link /test pj-rehearse
ci/prow/ci-operator-config-metadata 226e7ae link /test ci-operator-config-metadata
ci/build-farm/app-ci-config-dry 226e7ae link /test app-ci-config-dry
ci/build-farm/build02-dry 226e7ae link /test build02-dry
ci/prow/release-controller-config 226e7ae link /test release-controller-config
ci/prow/step-registry-metadata 226e7ae link /test step-registry-metadata

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stbenjam stbenjam closed this Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants