-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Enable e2e-metal-ipi on oc #8415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: stbenjam The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
If you do 4.4 and master, shouldn't you do 4.5 too? |
The last time I tried to add it to 4.5/4.6, DPTP told me a bot automatically does it. I don't know how often it runs but it does seem to happen sometimes: 3b5dca5 |
Sometimes doesn't sound convincing, why not just make it there, it definitely doesn't hurt 😉 |
|
It also doesn’t not hurt. I can add it later if the script doesn’t do it. I won’t be around for a few more hours to add it. It’d be nice if we could test the oc PR and unbreak us.... |
|
I guess it doesn't matter since openshift/oc#392 is approved and going to merge. I'll update this PR later when I'm on my computer. It seems odd to me that |
Nobody added it since there was no clear requirement, yet. e2e-cmd is different, in the long run it will turn to be part of regular e2e. |
|
@stbenjam: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@stbenjam: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
No description provided.