Skip to content

add e2e-azure as job to MCO#9607

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
kikisdeliveryservice:add-azure-mco
Jun 10, 2020
Merged

add e2e-azure as job to MCO#9607
openshift-merge-robot merged 1 commit into
openshift:masterfrom
kikisdeliveryservice:add-azure-mco

Conversation

@kikisdeliveryservice
Copy link
Copy Markdown
Contributor

@kikisdeliveryservice kikisdeliveryservice commented Jun 10, 2020

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2020
@abhinavdahiya
Copy link
Copy Markdown
Contributor

abhinavdahiya commented Jun 10, 2020

You can use steps to generate these.
see

release/ci-operator/config/openshift/installer/openshift-installer-master.yaml

Lines 149 to 152 in 0c2b49f

- as: e2e-azure
steps:
cluster_profile: azure4
workflow: openshift-e2e-azure 

make update

after adding those.

@kikisdeliveryservice
Copy link
Copy Markdown
Contributor Author

kikisdeliveryservice commented Jun 10, 2020

ahhh thanks will update!

@cgwalters
Copy link
Copy Markdown
Member

cgwalters commented Jun 10, 2020

/approve
to the idea! Only skimmed this, but one thought is that I think we basically want almost all of the same tests on openshift/installer and openshift/machine-config-operator - so if there's a way to factor those out into something shared that could help.

But seems sane to me, thanks for doing this!

@kikisdeliveryservice
Copy link
Copy Markdown
Contributor Author

kikisdeliveryservice commented Jun 10, 2020

when i run make update i get error:

time="2020-06-10T20:04:57Z" level=error msg="Failed to load CI Operator configuration" error="failed to load ci-operator config (error converting YAML to JSON: yaml: line 69: did not find expected key)" source-file=/go/src/github.com/openshift/release/ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-master.yaml
time="2020-06-10T20:04:57Z" level=fatal msg="Failed to generate jobs" error="failed to load ci-operator config (error converting YAML to JSON: yaml: line 69: did not find expected key)" source=/go/src/github.com/openshift/release/ci-operator/config subdir= target=/go/src/github.com/openshift/release/ci-operator/jobs
make[1]: *** [Makefile:42: jobs] Error 1

@ashcrow
Copy link
Copy Markdown
Member

ashcrow commented Jun 10, 2020

Thank you for adding this @kikisdeliveryservice!!

@kikisdeliveryservice
Copy link
Copy Markdown
Contributor Author

kikisdeliveryservice commented Jun 10, 2020

seeing same error that i see locally here: https://deck-ci.apps.ci.l2s4.p1.openshiftapps.com/view/gcs/origin-ci-test/pr-logs/pull/openshift_release/9607/pull-ci-openshift-release-master-generated-config/24335

@kikisdeliveryservice
Copy link
Copy Markdown
Contributor Author

kikisdeliveryservice commented Jun 10, 2020

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 10, 2020
@kikisdeliveryservice
Copy link
Copy Markdown
Contributor Author

kikisdeliveryservice commented Jun 10, 2020

/retest

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jun 10, 2020

@kikisdeliveryservice: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/pj-rehearse 0be96ca2eebdd43932a009ca518a932cbe0e541c link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/release-4.5/e2e-azure 9609cdc link /test pj-rehearse

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@abhinavdahiya
Copy link
Copy Markdown
Contributor

abhinavdahiya commented Jun 10, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2020
@runcom
Copy link
Copy Markdown
Member

runcom commented Jun 10, 2020

Awesome
/approve

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jun 10, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, cgwalters, kikisdeliveryservice, runcom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kikisdeliveryservice
Copy link
Copy Markdown
Contributor Author

kikisdeliveryservice commented Jun 10, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 10, 2020
@openshift-merge-robot openshift-merge-robot merged commit 921ec91 into openshift:master Jun 10, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jun 10, 2020

@kikisdeliveryservice: Updated the following 12 configmaps:

  • job-config-4.6 configmap in namespace ci at cluster api.ci using the following files:
    • key openshift-machine-config-operator-release-4.6-presubmits.yaml using file ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-release-4.6-presubmits.yaml
  • job-config-4.6 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-machine-config-operator-release-4.6-presubmits.yaml using file ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-release-4.6-presubmits.yaml
  • job-config-4.7 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-machine-config-operator-release-4.7-presubmits.yaml using file ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-release-4.7-presubmits.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-machine-config-operator-master.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-master.yaml
  • ci-operator-4.7-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-machine-config-operator-release-4.7.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.7.yaml
  • job-config-master configmap in namespace ci at cluster api.ci using the following files:
    • key openshift-machine-config-operator-master-presubmits.yaml using file ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-master-presubmits.yaml
  • job-config-master configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-machine-config-operator-master-presubmits.yaml using file ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-master-presubmits.yaml
  • job-config-4.5 configmap in namespace ci at cluster api.ci using the following files:
    • key openshift-machine-config-operator-release-4.5-presubmits.yaml using file ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-release-4.5-presubmits.yaml
  • job-config-4.5 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-machine-config-operator-release-4.5-presubmits.yaml using file ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-release-4.5-presubmits.yaml
  • job-config-4.7 configmap in namespace ci at cluster api.ci using the following files:
    • key openshift-machine-config-operator-release-4.7-presubmits.yaml using file ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-release-4.7-presubmits.yaml
  • ci-operator-4.5-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-machine-config-operator-release-4.5.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.5.yaml
  • ci-operator-4.6-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-machine-config-operator-release-4.6.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.6.yaml
Details

In response to this:

cc: @abhinavdahiya @cgwalters

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@runcom
Copy link
Copy Markdown
Member

runcom commented Jun 10, 2020 •
edited
Loading

Awesome 😍 thanks @kikisdeliveryservice !!!

@sinnykumari sinnykumari mentioned this pull request Apr 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashcrow ashcrow Awaiting requested review from ashcrow

@sinnykumari sinnykumari Awaiting requested review from sinnykumari

2 more reviewers

@wking wking wking left review comments

@abhinavdahiya abhinavdahiya abhinavdahiya left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@abhinavdahiya abhinavdahiya

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@kikisdeliveryservice @abhinavdahiya @cgwalters @ashcrow @openshift-ci-robot @runcom @wking @openshift-merge-robot