wait causing pipeline failure#9811
Conversation
hamzy
force-pushed
the
fix-wait-for-install-complete
branch
from
d914e77 to
0ebd419
Compare
…e to exit the shell
hamzy
force-pushed
the
fix-wait-for-install-complete
branch
from
0ebd419 to
175e0d2
Compare
|
@hamzy: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
/assign @adduarte |
|
|
||
| OS_DEBUG=1 TF_LOG=trace openshift-install --dir=/tmp/artifacts/installer create cluster --log-level=debug & | ||
| PID_OPENSHIFT_INSTALL=$! | ||
| echo "PID_OPENSHIFT_INSTALL=${PID_OPENSHIFT_INSTALL}" |
There was a problem hiding this comment.
For consistency around the wait. And so that it doesn't get lost from the copy files code block.
|
|
||
| # wait for installer create cluster and return its status | ||
| # disable errexit on pipeline failures for the wait command | ||
| set +e |
There was a problem hiding this comment.
Note to self: the RC handling which we're fixing up here was born with the template in #8271.
|
/lgtm This seems fine to fix the current logic, but we should have a bug about root-causing and resolving the need for a |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hamzy, jaypoulz, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@hamzy: Updated the following 4 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
6 participants
The wait command can return an error code causing the pipeline failure to exit the shell