enable cvo operator-esque make test-e2e e2e-aws-operator job for jenkins-client-plugin

[gabemontero]

ok @akram @waveywaves @bparees @adambkaplan here is the openshift/release side of getting a PR e2e test job for jenkins-client-plugin that I started in openshift/jenkins-client-plugin#335

when we are done here, we should have a test that runs against the PR's cluster using whatever jenkins-client-plugin changes the PR has, whether those for the plugin itself or the tests defined in the test subfolder.

let's see how the rehearsal jobs look

[gabemontero]

Hmm ...

 KUBERNETES_CONFIG=/tmp/admin.kubeconfig go test -parallel 1 -timeout 30m -v ./test/e2e/...
FAIL	github.com/openshift/jenkins-client-plugin/test/e2e [setup failed]
FAIL
# github.com/openshift/jenkins-client-plugin/test/e2e
package github.com/openshift/jenkins-client-plugin/test/e2e (test)
	imports github.com/openshift/api/build/v1: cannot find package "." in:
	/go/src/github.com/openshift/jenkins-client-plugin/vendor/github.com/openshift/api/build/v1
make: *** [test-e2e] Error 1 

So I think I need to try my go test invocation locally in where the only item in the GOPATH is my test, vs. when I try locally with all the other repos in my GOPATH

[gabemontero]

Even locally for me with a clean GOPATH I'm not seeing the problem in the rehearsal job.

Perhaps a golang diff?

Going to push a commit to jenkins-client-plugin to add some debug to the Makefile as well as a possible workaround (based on how we do go test in openshfit/jenkins)

[gabemontero]

Actually I think the vendor dir is not quite right .... go mod vendor produced valid changes

[gabemontero]

/retest

[akram]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akram, gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/jenkins-client-plugin/OWNERS [akram,gabemontero]
• ci-operator/jobs/openshift/jenkins-client-plugin/OWNERS [akram,gabemontero]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@gabemontero: Updated the following 3 configmaps:

• job-config-master configmap in namespace ci at cluster app.ci using the following files:
  • key openshift-jenkins-client-plugin-master-presubmits.yaml using file ci-operator/jobs/openshift/jenkins-client-plugin/openshift-jenkins-client-plugin-master-presubmits.yaml
• ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
  • key openshift-jenkins-client-plugin-master.yaml using file ci-operator/config/openshift/jenkins-client-plugin/openshift-jenkins-client-plugin-master.yaml
• job-config-master configmap in namespace ci at cluster api.ci using the following files:
  • key openshift-jenkins-client-plugin-master-presubmits.yaml using file ci-operator/jobs/openshift/jenkins-client-plugin/openshift-jenkins-client-plugin-master-presubmits.yaml

Details

In response to this:

ok @akram @waveywaves @bparees @adambkaplan here is the openshift/release side of getting a PR e2e test job for jenkins-client-plugin that I started in openshift/jenkins-client-plugin#335

when we are done here, we should have a test that runs against the PR's cluster using whatever jenkins-client-plugin changes the PR has, whether those for the plugin itself or the tests defined in the test subfolder.

let's see how the rehearsal jobs look

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.