Skip to content

base-ci-images: Add {ocp,origin}/builder:golang-1.14#9889

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
paulfantom:add_go_1.14
Jun 24, 2020
Merged

base-ci-images: Add {ocp,origin}/builder:golang-1.14#9889
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
paulfantom:add_go_1.14

Conversation

@paulfantom
Copy link
Copy Markdown
Contributor

@paulfantom paulfantom commented Jun 24, 2020

Needed for the Go 1.14 switch

A follow up to #9096

/cc @openshift/openshift-team-developer-productivity-test-platform @lilic @periklis

@openshift-ci-robot openshift-ci-robot requested review from a team, lilic and periklis June 24, 2020 13:31
Copy link
Copy Markdown
Contributor

@periklis periklis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, paulfantom, periklis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2020
@openshift-merge-robot openshift-merge-robot merged commit 8ce739f into openshift:master Jun 24, 2020
@paulfantom paulfantom deleted the add_go_1.14 branch June 24, 2020 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants