Bug 2050466: Not allow "" string in registriesConf entry#14
Bug 2050466: Not allow "" string in registriesConf entry#14openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
Fix: https://bugzilla.redhat.com/show_bug.cgi?id=2050466 Add validation to not allow empty string ("") if get it from Image and ICSP CRD. Empty string regsitries configurations will fail the machine config daemon operations of pulling images and the nodes will stopped in NotReady state when node rebooting after node drain. ``` 2022-02-03T23:16:02.952318066Z I0203 23:16:02.952259 2590 run.go:18] Running: podman pull -q --authfile /var/lib/kubelet/config.json quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:6d4ff6bb5494c55c24f9a322b1a5faffb8a92ea0f572f1078db55f3f1abaa588 2022-02-03T23:16:03.033231339Z Error: error loading registries configuration "/etc/containers/registries.conf": invalid condition: mirror location is unset ``` Signed-off-by: Qi Wang <qiwan@redhat.com>
QiWang19
changed the title
openshift-ci
Bot
added
the
bugzilla/severity-urgent
|
@QiWang19: This pull request references Bugzilla bug 2050466, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (schoudha@redhat.com), skipping review request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
Bot
added
the
bugzilla/valid-bug
|
@mtrmac PTAL. Add the validation in this repo to replace the openshift/machine-config-operator#2961 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mtrmac, QiWang19 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
@QiWang19: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@QiWang19: All pull requests linked via external trackers have merged: Bugzilla bug 2050466 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
3 participants
Fix: https://bugzilla.redhat.com/show_bug.cgi?id=2050466
Add validation to not allow empty string ("") if get it from Image and ICSP CRD.
Empty string regsitries configurations will fail the machine config daemon operations
of pulling images and the nodes will stopped in NotReady state when node rebooting after node drain.
Signed-off-by: Qi Wang qiwan@redhat.com