[release-4.6] Bug 1928773: Prefer local endpoint for cluster DNS service #261

Miciah · 2021-02-19T21:19:53Z

Bump the vendored github.com/openshift/kubernetes to pick up openshift/kubernetes@3a52825: "UPSTREAM: <carry>: Prefer local endpoint for cluster DNS service".

This bump incidentally picks up commit openshift/kubernetes@6d9f2fe: "UPSTREAM: 95252: Kube-proxy: Perf-fix: Shrink INPUT chain".

go.mod: Bump github.com/openshift/kubernetes.
go.sum:
vendor/modules.txt: Regenerate.
vendor/k8s.io/kubernetes/pkg/proxy/iptables/proxier.go: Bump.

openshift-ci-robot · 2021-02-19T21:20:59Z

@Miciah: This pull request references Bugzilla bug 1930917, which is invalid:

expected dependent Bugzilla bug 1930913 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead
expected dependent Bugzilla bug 1930913 to target a release in 4.7.0, but it targets "4.7.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Miciah · 2021-02-23T03:49:53Z

/retitle [release-4.6] Bug 1928773: Prefer local endpoint for cluster DNS service

openshift-ci-robot · 2021-02-23T03:50:09Z

@Miciah: This pull request references Bugzilla bug 1928773, which is invalid:

expected dependent Bugzilla bug 1928304 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead
expected dependent Bugzilla bug 1928304 to target a release in 4.7.0, but it targets "4.7.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

knobunc · 2021-02-24T18:51:55Z

/lgtm

openshift-bot · 2021-02-25T01:00:19Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-02-25T01:00:26Z

@openshift-bot: This pull request references Bugzilla bug 1928773, which is invalid:

expected dependent Bugzilla bug 1928304 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-02-26T01:00:30Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-02-26T01:00:37Z

@openshift-bot: This pull request references Bugzilla bug 1928773, which is invalid:

expected dependent Bugzilla bug 1928304 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-02-27T01:00:42Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-02-27T01:00:46Z

@openshift-bot: This pull request references Bugzilla bug 1928773, which is invalid:

expected dependent Bugzilla bug 1928304 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-02-28T01:00:52Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-02-28T01:00:57Z

@openshift-bot: This pull request references Bugzilla bug 1928773, which is invalid:

expected dependent Bugzilla bug 1928304 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-03-01T01:00:43Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-03-01T01:00:48Z

@openshift-bot: This pull request references Bugzilla bug 1928773, which is invalid:

expected dependent Bugzilla bug 1928304 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-03-02T01:00:38Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-03-02T01:00:43Z

@openshift-bot: This pull request references Bugzilla bug 1928773, which is invalid:

expected dependent Bugzilla bug 1928304 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Bump the vendored github.com/openshift/kubernetes to pick up commit 05e619e27cf622ecc153b91d7971e094c14335ad: "UPSTREAM: <carry>: Prefer local endpoint for cluster DNS service". This bump incidentally picks up commit 6d9f2fe774e6ad19a8c538c76610f3277d05f30f: "UPSTREAM: 95252: Kube-proxy: Perf-fix: Shrink INPUT chain". This commit fixes bug 1930917. https://bugzilla.redhat.com/show_bug.cgi?id=1930917 * go.mod: Bump github.com/openshift/kubernetes. * go.sum: * vendor/modules.txt: Regenerate. * vendor/k8s.io/kubernetes/pkg/proxy/iptables/proxier.go: Bump.

Miciah · 2021-03-02T16:15:57Z

Rebased now that openshift/kubernetes#581 has merged.

Miciah · 2021-03-02T19:40:46Z

Looks like kube-apiserver didn't finish rolling out before the test ended, but it isn't obvious what the root cause for that is, and I don't see any network-related errors.
/test e2e-gcp

Miciah · 2021-03-02T22:13:29Z

Many tests failed with errors like the following:

E0302 20:36:21.980429   87985 test_context.go:457] Failed to setup provider config for "gce": Error building GCE/GKE provider: unexpected response listing zones: googleapi: Error 403: Quota exceeded for quota group 'ListGroup' and limit 'List requests per 100 seconds' of service 'compute.googleapis.com' for consumer 'project_number:1053217076791'., rateLimitExceeded

/test e2e-gcp

Miciah · 2021-03-02T22:18:06Z

Looks like there's been some activity to address the rate limiting issue: openshift/release#16256, but evidently it isn't completely resolved.

Miciah · 2021-03-03T15:24:21Z

/test e2e-gcp

Miciah · 2021-03-03T17:13:37Z

Still hitting GCE API rate limiting...
/test e2e-gcp

Miciah · 2021-03-03T19:24:19Z

/test e2e-gcp

dcbw · 2021-03-03T22:12:10Z

/lgtm

openshift-ci-robot · 2021-03-03T22:12:34Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw, knobunc, Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [dcbw,knobunc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-03-04T01:00:54Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-03-04T01:00:58Z

@openshift-bot: This pull request references Bugzilla bug 1928773, which is invalid:

expected dependent Bugzilla bug 1928304 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

lihongan · 2021-03-04T03:27:46Z

/bugzilla refresh

openshift-ci-robot · 2021-03-04T03:27:52Z

@lihongan: This pull request references Bugzilla bug 1928773, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.z) matches configured target release for branch (4.6.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1928304 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1928304 targets the "4.7.z" release, which is one of the valid target releases: 4.7.0, 4.7.z
bug has dependents

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2021-03-04T15:38:18Z

@Miciah: This pull request references Bugzilla bug 1928773, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.z) matches configured target release for branch (4.6.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1928304 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1928304 targets the "4.7.z" release, which is one of the valid target releases: 4.7.0, 4.7.z
bug has dependents

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

derekwaynecarr · 2021-03-04T16:28:04Z

(Patch-Manager) approved.

openshift-ci-robot · 2021-03-04T18:55:01Z

@Miciah: All pull requests linked via external trackers have merged:

Bugzilla bug 1928773 has been moved to the MODIFIED state.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This PR does the equivalent of openshift/sdn#261 for OVN-K. We can remove this hack when we support ITP:preferLocal in the future. Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>

This PR does the equivalent of openshift/sdn#261 for OVN-K. We can remove this hack when we support ITP:preferLocal in the future. Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com> (cherry picked from commit bfe85db) Conflicts: go-controller/pkg/ovn/controller/services/load_balancer.go just a minor comment conflict since ETP=local and LGW refactor don't exist in 4.9

openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 19, 2021

openshift-ci-robot requested review from aojea and squeed February 19, 2021 21:21

Miciah changed the title ~~Bug 1930917: Prefer local endpoint for cluster DNS service~~ [release-4.6] Bug 1930917: Prefer local endpoint for cluster DNS service Feb 19, 2021

Miciah force-pushed the BZ1930917-prefer-local-endpoint-for-cluster-DNS-service branch from 2bc5641 to db3b86f Compare February 19, 2021 21:30

openshift-ci-robot changed the title ~~[release-4.6] Bug 1930917: Prefer local endpoint for cluster DNS service~~ [release-4.6] Bug 1928773: Prefer local endpoint for cluster DNS service Feb 23, 2021

Miciah mentioned this pull request Feb 23, 2021

[sdn-4.6-kubernetes-1.18.6] Bug 1928773: UPSTREAM: <carry>: Prefer local endpoint for cluster DNS service openshift/kubernetes#581

Merged

openshift-ci-robot assigned knobunc Feb 24, 2021

openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 24, 2021

Miciah force-pushed the BZ1930917-prefer-local-endpoint-for-cluster-DNS-service branch from db3b86f to 8a95b1a Compare March 2, 2021 16:15

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 2, 2021

openshift-ci-robot assigned dcbw Mar 3, 2021

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2021

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 4, 2021

derekwaynecarr added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 4, 2021

openshift-ci-robot mentioned this pull request Mar 4, 2021

[release-4.6] Bug 1928773: Set CoreDNS readiness probe period and timeout each to 3 seconds openshift/cluster-dns-operator#236

Merged

openshift-merge-robot merged commit 0949e4b into openshift:release-4.6 Mar 4, 2021

tssurya mentioned this pull request Jan 11, 2022

Bug 2039698: Hacky way of doing ITP:preferLocal for openshift-dns:default openshift/ovn-kubernetes#896

Merged

tssurya mentioned this pull request Feb 22, 2022

[release-4.9] Bug 2055317: Hack ITP:preferLocal for DNS service openshift/ovn-kubernetes#964

Merged

[release-4.6] Bug 1928773: Prefer local endpoint for cluster DNS service #261

[release-4.6] Bug 1928773: Prefer local endpoint for cluster DNS service #261

Uh oh!

Conversation

Miciah commented Feb 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Feb 19, 2021

Uh oh!

Miciah commented Feb 23, 2021

Uh oh!

openshift-ci-robot commented Feb 23, 2021

Uh oh!

knobunc commented Feb 24, 2021

Uh oh!

openshift-bot commented Feb 25, 2021

Uh oh!

openshift-ci-robot commented Feb 25, 2021

Uh oh!

openshift-bot commented Feb 26, 2021

Uh oh!

openshift-ci-robot commented Feb 26, 2021

Uh oh!

openshift-bot commented Feb 27, 2021

Uh oh!

openshift-ci-robot commented Feb 27, 2021

Uh oh!

openshift-bot commented Feb 28, 2021

Uh oh!

openshift-ci-robot commented Feb 28, 2021

Uh oh!

openshift-bot commented Mar 1, 2021

Uh oh!

openshift-ci-robot commented Mar 1, 2021

Uh oh!

openshift-bot commented Mar 2, 2021

Uh oh!

openshift-ci-robot commented Mar 2, 2021

Uh oh!

Miciah commented Mar 2, 2021

Uh oh!

Miciah commented Mar 2, 2021

Uh oh!

Miciah commented Mar 2, 2021

Uh oh!

Miciah commented Mar 2, 2021

Uh oh!

Miciah commented Mar 3, 2021

Uh oh!

Miciah commented Mar 3, 2021

Uh oh!

Miciah commented Mar 3, 2021

Uh oh!

dcbw commented Mar 3, 2021

Uh oh!

openshift-ci-robot commented Mar 3, 2021

Uh oh!

openshift-bot commented Mar 4, 2021

Uh oh!

openshift-ci-robot commented Mar 4, 2021

Uh oh!

lihongan commented Mar 4, 2021

Uh oh!

openshift-ci-robot commented Mar 4, 2021

Uh oh!

openshift-ci-robot commented Mar 4, 2021

Uh oh!

derekwaynecarr commented Mar 4, 2021

Uh oh!

openshift-ci-robot commented Mar 4, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Miciah commented Feb 19, 2021 •

edited

Loading