Skip to content

Bug 1794024: [4.3] Update deps, including informer fix #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 3 commits into from
Feb 20, 2020
Merged

Bug 1794024: [4.3] Update deps, including informer fix #94

openshift-merge-robot merged 3 commits into from
Feb 20, 2020

Conversation

@danwinship
Copy link
Contributor

@danwinship danwinship commented Jan 20, 2020 •
edited
Loading

4.3 version of #93

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 20, 2020

@danwinship: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

WIP: [4.3] Use k8s.io/client-go fork with informer fix, run update-deps

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 20, 2020
@danwinship
Copy link
Contributor Author

danwinship commented Jan 21, 2020

/test all

1 similar comment
@danwinship
Copy link
Contributor Author

danwinship commented Jan 21, 2020

/test all

@danwinship danwinship force-pushed the fork-k8s-client-go-4.3 branch from ead0151 to 12aafa9 Compare January 22, 2020 13:48
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 22, 2020

@danwinship: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

WIP: [4.3] Use k8s.io/client-go fork with informer fix, run update-deps

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danwinship danwinship changed the title WIP: [4.3] Use k8s.io/client-go fork with informer fix, run update-deps [4.3] Update deps, including informer fix Jan 22, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 22, 2020

@danwinship: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[4.3] Update deps, including informer fix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 22, 2020
@danwinship danwinship changed the title [4.3] Update deps, including informer fix Bug 1794024: [4.3] Update deps, including informer fix Jan 22, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 22, 2020

@danwinship: This pull request references Bugzilla bug 1794024, which is invalid:

  • expected the bug to target the "4.3.0" release, but it targets "4.3.z" instead
  • expected dependent Bugzilla bug 1794022 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1794024: [4.3] Update deps, including informer fix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 22, 2020
@danwinship
Copy link
Contributor Author

danwinship commented Jan 25, 2020

/retest
/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 25, 2020

@danwinship: This pull request references Bugzilla bug 1794024, which is invalid:

  • expected dependent Bugzilla bug 1794022 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/retest
/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danwinship
Copy link
Contributor Author

danwinship commented Jan 31, 2020

/retest
/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 31, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 31, 2020

@danwinship: This pull request references Bugzilla bug 1794024, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/retest
/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 31, 2020
@dcbw
Copy link
Contributor

dcbw commented Feb 5, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 5, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, dcbw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bparees bparees added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 19, 2020
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 20, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 20, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 99812ae into openshift:release-4.3 Feb 20, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 20, 2020

@danwinship: All pull requests linked via external trackers have merged. Bugzilla bug 1794024 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1794024: [4.3] Update deps, including informer fix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danwinship danwinship deleted the fork-k8s-client-go-4.3 branch March 25, 2020 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcbw dcbw Awaiting requested review from dcbw

@squeed squeed Awaiting requested review from squeed

Assignees

@dcbw dcbw

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@danwinship @openshift-ci-robot @dcbw @openshift-bot @bparees @openshift-merge-robot