Skip to content

MCO-1652: Add MCO suite tracking#2579

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
yuqi-zhang:add-mco-suite
May 21, 2025
Merged

MCO-1652: Add MCO suite tracking#2579
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
yuqi-zhang:add-mco-suite

Conversation

@yuqi-zhang
Copy link
Copy Markdown
Contributor

Follow up to openshift/release#64752 and openshift/origin#29776

Just a draft for now, but since the original tests were added to serial directly and have reached the necessary pass rates before, I went ahead and added it to the views as well for 4.20.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 9, 2025
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 9, 2025

@yuqi-zhang: This pull request references MCO-1652 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

Follow up to openshift/release#64752 and openshift/origin#29776

Just a draft for now, but since the original tests were added to serial directly and have reached the necessary pass rates before, I went ahead and added it to the views as well for 4.20.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 9, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 9, 2025
@yuqi-zhang
Copy link
Copy Markdown
Contributor Author

/test all

Comment thread pkg/variantregistry/ocp.go Outdated
{"-etcd-scaling", "etcd-scaling"},
{"conformance", "parallel"}, // Jobs with "conformance" but no explicit serial are probably parallel
{"usernamespace", "usernamespace"},
{"machine-config-operator", "machine-config-operator"},
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would use Procedure variant here, we're looking to remove Suite. It can't be reliably detected.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 15, 2025
@yuqi-zhang yuqi-zhang marked this pull request as ready for review May 15, 2025 23:35
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 15, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 15, 2025
@openshift-ci openshift-ci Bot requested review from DennisPeriquet and xueqzhan May 15, 2025 23:36
@yuqi-zhang
Copy link
Copy Markdown
Contributor Author

Updated to variant per suggestion and removed view since we don't need a decided view yet

@neisw
Copy link
Copy Markdown
Contributor

neisw commented May 20, 2025

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neisw, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 21, 2025

@yuqi-zhang: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 2e5f032 into openshift:main May 21, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants