Skip to content

Use resource timeout with deleteVolumeSnapshots#266

Merged
sseago merged 1 commit into
openshift:konveyor-devfrom
sseago:vsc-deletion2
May 9, 2023
Merged

Use resource timeout with deleteVolumeSnapshots#266
sseago merged 1 commit into
openshift:konveyor-devfrom
sseago:vsc-deletion2

Conversation

@sseago
Copy link
Copy Markdown

@sseago sseago commented May 9, 2023

No description provided.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 9, 2023

@sseago: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sseago
Copy link
Copy Markdown
Author

sseago commented May 9, 2023

/cherry-pick oadp-1.2

@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented May 9, 2023

@sseago: once the present PR merges, I will cherry-pick it on top of oadp-1.2 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick oadp-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 9, 2023
weshayutin
weshayutin approved these changes May 9, 2023
View reviewed changes
Copy link
Copy Markdown

@weshayutin weshayutin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and WFM :) Thanks Scott!

@weshayutin
Copy link
Copy Markdown

weshayutin commented May 9, 2023

/lgtm

@weshayutin weshayutin added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2023
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: shubham-pampattiwar, sseago, weshayutin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sseago sseago merged commit 31f3427 into openshift:konveyor-dev May 9, 2023
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented May 9, 2023

@sseago: new pull request created: #267

Details

In response to this:

/cherry-pick oadp-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weshayutin weshayutin weshayutin approved these changes

@shubham-pampattiwar shubham-pampattiwar shubham-pampattiwar approved these changes

Assignees

@weshayutin weshayutin

@shubham-pampattiwar shubham-pampattiwar

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sseago @openshift-cherrypick-robot @weshayutin @shubham-pampattiwar