run oadp-operator e2e test from the velero repo by weshayutin · Pull Request #353 · openshift/velero

weshayutin · 2024-10-15T19:44:53Z

execute openshift/oadp-operator e2e tests directly against the velero repo locally or via prow ci

Thank you for contributing to Velero!

Please add a summary of your change

execute openshift/oadp-operator e2e tests directly against the velero repo locally or via prow ci

to test

optional: update the VELERO_IMAGE variable
execute: make -f Makefile.prow test-e2e

execute openshift/oadp-operator e2e tests directly against the velero repo locally or via prow ci Signed-off-by: Wesley Hayutin <weshayutin@gmail.com>

weshayutin · 2024-10-15T19:46:48Z

locally tested:

    Mongo application DATAMOVER
    /tmp/oadp-operator/tests/e2e/must-gather_suite_test.go:75
------------------------------
[AfterSuite] 
/tmp/oadp-operator/tests/e2e/e2e_suite_test.go:198
  > Enter [AfterSuite] TOP-LEVEL - /tmp/oadp-operator/tests/e2e/e2e_suite_test.go:198 @ 10/15/24 13:36:33.389
2024/10/15 13:36:33 Deleting Secrets
2024/10/15 13:36:33 Deleting DPA
  < Exit [AfterSuite] TOP-LEVEL - /tmp/oadp-operator/tests/e2e/e2e_suite_test.go:198 @ 10/15/24 13:36:33.595 (206ms)
[AfterSuite] PASSED [0.206 seconds]
------------------------------

Ran 1 of 33 Specs in 253.674 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 32 Skipped
PASS

Signed-off-by: Wesley Hayutin <weshayutin@gmail.com>

mateusoliveira43 · 2024-10-16T20:29:21Z

tested and idea is working (i.e. unsupported override is used in tests)

spec:
  backupLocations:
    - velero:
        config:
          profile: default
          region: ...
          s3ForcePathStyle: 'true'
          s3Url: '...'
        credential:
          key: cloud
          name: bsl-cloud-credentials-ibmcloud
        default: true
        objectStorage:
          bucket: ...
          prefix: velero-e2e-...
        provider: aws
  configuration:
    nodeAgent:
      enable: true
      podConfig:
        resourceAllocations: {}
      uploaderType: kopia
    velero:
      defaultPlugins:
        - openshift
        - aws
        - csi
      featureFlags:
        - EnableCSI
      logLevel: debug
  podDnsConfig: {}
  unsupportedOverrides:
    awsPluginImageFqin: ''
    azurePluginImageFqin: ''
    gcpPluginImageFqin: ''
    kubevirtPluginImageFqin: ''
    nonAdminControllerImageFqin: ''
    openshiftPluginImageFqin: ''
    resticRestoreImageFqin: ''
    veleroImageFqin: 'quay.io/konveyor/velero:latest'

But it still not clear to me how this will work in CI. Along CI image name, we also need OADP operator installed to run the tests

kaovilai

simplifies ENV used in Makefile

kaovilai · 2024-10-16T20:32:56Z

we also need OADP operator installed to run the tests

hopefully ocp/release repo test config can make it so operator is already installed, if not we can follow up later.

Co-authored-by: Tiger Kaovilai <passawit.kaovilai@gmail.com>

weshayutin · 2024-10-16T20:46:10Z

tested and idea is working (i.e. unsupported override is used in tests)

spec:
  backupLocations:
    - velero:
        config:
          profile: default
          region: ...
          s3ForcePathStyle: 'true'
          s3Url: '...'
        credential:
          key: cloud
          name: bsl-cloud-credentials-ibmcloud
        default: true
        objectStorage:
          bucket: ...
          prefix: velero-e2e-...
        provider: aws
  configuration:
    nodeAgent:
      enable: true
      podConfig:
        resourceAllocations: {}
      uploaderType: kopia
    velero:
      defaultPlugins:
        - openshift
        - aws
        - csi
      featureFlags:
        - EnableCSI
      logLevel: debug
  podDnsConfig: {}
  unsupportedOverrides:
    awsPluginImageFqin: ''
    azurePluginImageFqin: ''
    gcpPluginImageFqin: ''
    kubevirtPluginImageFqin: ''
    nonAdminControllerImageFqin: ''
    openshiftPluginImageFqin: ''
    resticRestoreImageFqin: ''
    veleroImageFqin: 'quay.io/konveyor/velero:latest'

But it still not clear to me how this will work in CI. Along CI image name, we also need OADP operator installed to run the tests

ya.. not sure if we'll do that via prow or via this makefile. If we DO need to do it via this makefile, wouldn't just a be a make deploy-olm from the oadp-operator dir? EASY no?

done1

kaovilai · 2024-10-16T21:06:19Z

make deploy-olm from the oadp-operator dir? EASY no?

deploy, and setup credentials stuff in prow so to not expose secrets in this makefile

Signed-off-by: Wesley Hayutin <weshayutin@gmail.com>

Co-authored-by: Tiger Kaovilai <passawit.kaovilai@gmail.com>

openshift-ci · 2024-10-16T22:16:25Z

@weshayutin: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

mpryc · 2024-10-17T08:37:19Z

/lgtm

* run oadp-operator e2e test from the velero repo execute openshift/oadp-operator e2e tests directly against the velero repo locally or via prow ci Signed-off-by: Wesley Hayutin <weshayutin@gmail.com> * update variable names, add a cleanup * make sure env variable overrides default velero_image Signed-off-by: Wesley Hayutin <weshayutin@gmail.com> * add options to build, push, and only test Signed-off-by: Wesley Hayutin <weshayutin@gmail.com> * add arch to name Signed-off-by: Wesley Hayutin <weshayutin@gmail.com> * remove duplicated clean/rm operator checkout * simplify by dropping export var and use a oneliner Co-authored-by: Tiger Kaovilai <passawit.kaovilai@gmail.com> * drop export and use oneliner Co-authored-by: Tiger Kaovilai <passawit.kaovilai@gmail.com> * just in case, allow oadp to be deployed from makefile Signed-off-by: Wesley Hayutin <weshayutin@gmail.com> * Update Makefile.prow Co-authored-by: Tiger Kaovilai <passawit.kaovilai@gmail.com> --------- Signed-off-by: Wesley Hayutin <weshayutin@gmail.com> Co-authored-by: Tiger Kaovilai <passawit.kaovilai@gmail.com>

run oadp-operator e2e test from the velero repo

636f77b

execute openshift/oadp-operator e2e tests directly against the velero repo locally or via prow ci Signed-off-by: Wesley Hayutin <weshayutin@gmail.com>

mateusoliveira43 reviewed Oct 15, 2024

View reviewed changes

Comment thread Makefile.prow Outdated

kaovilai reviewed Oct 15, 2024

View reviewed changes

Comment thread Makefile.prow Outdated

update variable names, add a cleanup

56de37d

kaovilai mentioned this pull request Oct 15, 2024

e2e: Support CRC "cloud provider" openshift/oadp-operator#1563

Open

make sure env variable overrides default velero_image

b1b75f2

Signed-off-by: Wesley Hayutin <weshayutin@gmail.com>

kaovilai reviewed Oct 16, 2024

View reviewed changes

Comment thread Makefile.prow

add options to build, push, and only test

f36b26c

Signed-off-by: Wesley Hayutin <weshayutin@gmail.com>

kaovilai reviewed Oct 16, 2024

View reviewed changes

Comment thread Makefile.prow Outdated

add arch to name

ff05c64

Signed-off-by: Wesley Hayutin <weshayutin@gmail.com>

mateusoliveira43 reviewed Oct 16, 2024

View reviewed changes

Comment thread Makefile.prow

remove duplicated clean/rm operator checkout

b770987

kaovilai previously requested changes Oct 16, 2024

View reviewed changes

Comment thread Makefile.prow Outdated

Comment thread Makefile.prow Outdated

weshayutin and others added 2 commits October 16, 2024 14:41

simplify by dropping export var and use a oneliner

7b7bc8d

Co-authored-by: Tiger Kaovilai <passawit.kaovilai@gmail.com>

drop export and use oneliner

4ec125f

Co-authored-by: Tiger Kaovilai <passawit.kaovilai@gmail.com>

just in case, allow oadp to be deployed from makefile

13f16f2

Signed-off-by: Wesley Hayutin <weshayutin@gmail.com>

kaovilai reviewed Oct 16, 2024

View reviewed changes

Comment thread Makefile.prow Outdated

Update Makefile.prow

8052398

Co-authored-by: Tiger Kaovilai <passawit.kaovilai@gmail.com>

kaovilai approved these changes Oct 16, 2024

View reviewed changes

mpryc approved these changes Oct 17, 2024

View reviewed changes

openshift-ci Bot assigned mpryc Oct 17, 2024

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

run oadp-operator e2e test from the velero repo#353

run oadp-operator e2e test from the velero repo#353
openshift-merge-bot[bot] merged 10 commits intoopenshift:konveyor-devfrom
weshayutin:oadp_e2e_velero

weshayutin commented Oct 15, 2024

Uh oh!

weshayutin commented Oct 15, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mateusoliveira43 commented Oct 16, 2024 •

edited

Loading

Uh oh!

kaovilai left a comment

Uh oh!

Uh oh!

Uh oh!

kaovilai commented Oct 16, 2024

Uh oh!

weshayutin commented Oct 16, 2024

Uh oh!

kaovilai commented Oct 16, 2024

Uh oh!

Uh oh!

openshift-ci Bot commented Oct 16, 2024

Uh oh!

mpryc commented Oct 17, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

weshayutin commented Oct 15, 2024

Please add a summary of your change

to test

Uh oh!

weshayutin commented Oct 15, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mateusoliveira43 commented Oct 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kaovilai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

kaovilai commented Oct 16, 2024

Uh oh!

weshayutin commented Oct 16, 2024

Uh oh!

kaovilai commented Oct 16, 2024

Uh oh!

Uh oh!

openshift-ci Bot commented Oct 16, 2024

Uh oh!

mpryc commented Oct 17, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mateusoliveira43 commented Oct 16, 2024 •

edited

Loading