Skip to content

'Failing' type to 'Degraded' change in nw operator use cases#177

Merged
akostadinov merged 10 commits intoopenshift:masterfrom
anuragthehatter:OC-22706
Apr 24, 2019
Merged

'Failing' type to 'Degraded' change in nw operator use cases#177
akostadinov merged 10 commits intoopenshift:masterfrom
anuragthehatter:OC-22706

Conversation

@anuragthehatter
Copy link
Copy Markdown
Contributor

@anuragthehatter anuragthehatter commented Apr 24, 2019

Nothing big but just changed 'Failing' type to 'Degraded' in scenarios due to openshift/cluster-network-operator#147 .Confirmed Tests works fine after this change
PTAL @bmeng @zhaozhanqi

@openshift-ci-robot openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 24, 2019
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 24, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: anuragthehatter
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: akostadinov

If they are not already assigned, you can assign the PR to them by writing /assign @akostadinov in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@anuragthehatter
Merge branch 'master' of https://github.com/openshift/verification-tests
d394771 
 into OC-22706

Conflicts:
	features/networking/operator.feature
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 24, 2019
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 24, 2019
@anuragthehatter
Copy link
Copy Markdown
Contributor Author

anuragthehatter commented Apr 24, 2019

Confirmed all test worked fine locally after latest commit (networking.rb and all nw operator scenarios). Thanks!

akostadinov
akostadinov reviewed Apr 24, 2019
View reviewed changes
Comment thread features/networking/operator.feature Outdated
@akostadinov akostadinov merged commit 0f94820 into openshift:master Apr 24, 2019
@anuragthehatter anuragthehatter deleted the OC-22706 branch March 27, 2020 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akostadinov akostadinov akostadinov left review comments

@pruan-rht pruan-rht Awaiting requested review from pruan-rht

Assignees

No one assigned

Labels

size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@anuragthehatter @openshift-ci-robot @akostadinov