Skip to content

Conversation

@pruan-rht
Copy link
Member

… instead of User ojbect

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 24, 2019
@pruan-rht pruan-rht removed the request for review from cjryan February 24, 2019 06:01
@pruan-rht pruan-rht added the CoreAutomation Framework related label Feb 24, 2019
@pruan-rht
Copy link
Member Author

this applies to v3 branch


When /^I perform the :([a-z_]*?) rest request$/ do |yaml_key|
@result = env.rest_request_executor.exec(user: user, req: yaml_key.to_sym)
@result = user.rest_request(yaml_key.to_sym)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sehr gut

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akostadinov...had to do Google Translate this...now I know a German phrase. :)

@akostadinov
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akostadinov, pruan-rht

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2019
@openshift-merge-robot openshift-merge-robot merged commit 3f1a662 into openshift:master Feb 25, 2019
@pruan-rht pruan-rht deleted the fix_rest_request_step branch February 25, 2019 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. CoreAutomation Framework related lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants