Skip to content

Conversation

@lyman9966
Copy link
Contributor

for auto test, modify rest_openshift.rb

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lyman9966
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: cjryan

If they are not already assigned, you can assign the PR to them by writing /assign @cjryan in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 26, 2019
@lyman9966
Copy link
Contributor Author

@openshift/qe-pod , pls help review

@weinliu
Copy link
Contributor

weinliu commented Feb 26, 2019

@akostadinov could you help to take a look? Thanks!

@pruan-rht
Copy link
Member

@lyman9966 @weinliu, Thank you for the PR, but I'm going to close this one because #88 covers all existing rest api changes. BTW, oapi has been removed for 4.0.

@pruan-rht pruan-rht closed this Feb 26, 2019
@pruan-rht
Copy link
Member

@lyman9966 and @weinliu FYI, #88 has been merged. Please file issues if you are still blocked. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants