[release-4.9] [vsphere] create machineset spec based on machineset spec created at install time#694
Merged
openshift-merge-robot merged 1 commit intoSep 21, 2021
Conversation
The intent of this PR is to derive the Workspace for machinesets created during testing based on the compute machineset provisioned by the cluster at installation. The reason for this change is that a vCenter in IBM Cloud is being also used to run CI jobs from a shared lease pool to increase test coverage in some key configurations. Additionally, the vmTemplate can now be optionally defined as an environment variable in the e2e test script.
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aravindhp, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
mansikulkarni96
pushed a commit
to mansikulkarni96/windows-machine-config-operator
that referenced
this pull request
Aug 7, 2023
…penshift-cherrypick-robot/cherry-pick-669-to-release-4.9 Updated upstream source commit. Commit details follow: Project: https://github.com/openshift/windows-machine-config-operator.git Branch: release-4.9 Commit: 9751a44 Author: OpenShift Merge Robot Date: Tue, 21 Sep 2021 19:15:59 -0400 Merge pull request openshift#694 from openshift-cherrypick-robot/cherry-pick-669-to-release-4.9 [release-4.9] [vsphere] create machineset spec based on machineset spec created at install time Additional included commits: 1bf562a, d377196, 7d28b67 Referenced RedHat BugZilla bug: BZ#2002961 automerge: yes x-md5: 31d62c773595334678c436509a0c7fae Change-Id: I286d63b7fd2ef5c77031bef876e654d52e87f3ba
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #669
/assign aravindhp