-
-
Notifications
You must be signed in to change notification settings - Fork 7
[日付入力] 日付入力ライブラリを tempusdominus-bootstrap-4 → @eonasdan/tempus-dominus v6に切替 OW-2520 #2152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the date input library from tempusdominus-bootstrap-4 to @eonasdan/tempus-dominus v6 to support newer features and maintain up‐to‐date dependencies.
- Removed the old tempusdominus-bootstrap-4 require call.
- Introduced the new @eonasdan/tempus-dominus library for date/time picker support.
Files not reviewed (19)
- package.json: Language not supported
- public/css/connect.css: Language not supported
- public/js/app.js.LICENSE.txt: Language not supported
- public/mix-manifest.json: Language not supported
- resources/sass/app.scss: Language not supported
- resources/views/core/cms_frame_edit.blade.php: Language not supported
- resources/views/plugins/common/datetimepicker.blade.php: Language not supported
- resources/views/plugins/manage/holiday/edit.blade.php: Language not supported
- resources/views/plugins/manage/log/log.blade.php: Language not supported
- resources/views/plugins/manage/reservation/bookings.blade.php: Language not supported
- resources/views/plugins/manage/reservation/edit.blade.php: Language not supported
- resources/views/plugins/user/blogs/default/blogs_input.blade.php: Language not supported
- resources/views/plugins/user/blogs/default/blogs_list_categories.blade.php: Language not supported
- resources/views/plugins/user/blogs/default/blogs_setting_frame.blade.php: Language not supported
- resources/views/plugins/user/calendars/default/edit.blade.php: Language not supported
- resources/views/plugins/user/databases/default/databases_input.blade.php: Language not supported
- resources/views/plugins/user/databases/default/databases_input_date.blade.php: Language not supported
- resources/views/plugins/user/databases/default/databases_input_time.blade.php: Language not supported
- resources/views/plugins/user/faqs/default/faqs_input.blade.php: Language not supported
Comments suppressed due to low confidence (2)
resources/js/bootstrap.js:63
- [nitpick] If the old library is no longer used, please remove the commented-out require statement to clean up the code.
// require('tempusdominus-bootstrap-4');
resources/js/bootstrap.js:67
- [nitpick] Consider using a consistent import style (e.g. using ES module import) if the rest of the project follows that convention for module loading.
window.tempusDominus = require('@eonasdan/tempus-dominus');
… require して取り込むよう見直し
This was referenced Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
resources/views/plugins/common/datetimepicker.blade.phpの共通bladeを使うように対応npmライブラリ 更新コマンド
コマンド実行結果
※ js/707.jsは @popperjs/core。Tempus Dominus Date/Time Pickerで使用
github actionsでテスト
https://github.com/opensource-workshop/connect-cms/actions/runs/14102104528
→ エラーなしを確認
wiki修正済み
レビュー完了希望日
なし
関連Pull requests/Issues
参考
https://getdatepicker.com/6/options/
https://getdatepicker.com/6/installing.html
https://qiita.com/yaju/items/247813a10546353bd7c8
https://stackoverflow.com/questions/71537172/how-do-i-add-popper-js-to-a-laravel-8-with-bootstrap-5-project
https://getbootstrap.jp/docs/4.2/components/tooltips/
DB変更の有無
無し
チェックリスト