Skip to content

Conversation

@akagane99
Copy link
Contributor

@akagane99 akagane99 commented Mar 25, 2025

概要

  • 日付入力ライブラリの tempusdominus-bootstrap-4 を @eonasdan/tempus-dominus (v6) に切り替えます。
  • datetimepickerのjavascriptは resources/views/plugins/common/datetimepicker.blade.php の共通bladeを使うように対応
  • 確認済み
    • サブディレクトリで動作する事を目検で確認済み
    • @popperjs/core (v2) と popper.js (v1) を両方入れても、bootstrap4 の ツールチップ(popper.js (v1) )が表示する事を目検で確認済み

npmライブラリ 更新コマンド

npm uninstall tempusdominus-bootstrap-4
npm i --save-dev @popperjs/core @eonasdan/tempus-dominus

# ライブラリの最新化
npm update

# app.js, app.cssの最新化
npm run prod

コマンド実行結果

root@37ea93425cea:/var/www/html/connect-cms# npm update

up to date, audited 793 packages in 16s

116 packages are looking for funding
  run `npm fund` for details

3 vulnerabilities (1 low, 2 moderate)

To address all issues (including breaking changes), run:
  npm audit fix --force

Run `npm audit` for details.
root@37ea93425cea:/var/www/html/connect-cms# npm run prod

> prod
> npm run production


> production
> mix --production


● Mix █████████████████████████ done (99%) plugins 
 BuildCallbackPlugin

● Mix █████████████████████████ done (99%) plugins 
 WebpackBar:done

✔ Mix
  Compiled successfully in 7.95s
                         
   Laravel Mix v6.0.49   
                         

✔ Compiled Successfully in 7777ms
┌───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┬──────────┐
│                                                                                                                                                                          File │ Size     │
├───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┼──────────┤
│                                                                                                                                                                    /js/app.js │ 1.49 MiB │
│                                                                                                                                                        /js/app.js.LICENSE.txt │ 2.9 KiB  │
│                                                                                                                                                                   css/app.css │ 285 KiB  │
│                                                                              fonts/vendor/@fortawesome/fontawesome-free/webfa-brands-400.ttf?1815e00441357e01619e5793e1caa78a │ 206 KiB  │
│                                                                            fonts/vendor/@fortawesome/fontawesome-free/webfa-brands-400.woff2?c210719e60948b211a1260f79812efe5 │ 116 KiB  │
│                                                                             fonts/vendor/@fortawesome/fontawesome-free/webfa-regular-400.ttf?914997e1bdfc990d0897cdaba877a0b3 │ 66.5 KiB │
│                                                                           fonts/vendor/@fortawesome/fontawesome-free/webfa-regular-400.woff2?89999bdf5d835c0120257222e5568fec │ 24.9 KiB │
│                                                                               fonts/vendor/@fortawesome/fontawesome-free/webfa-solid-900.ttf?2582b0e4bcf85eceead0de3fd9035c90 │ 416 KiB  │
│                                                                             fonts/vendor/@fortawesome/fontawesome-free/webfa-solid-900.woff2?2463b90d9a316e4e5294e6706b6a7a72 │ 155 KiB  │
│                                                                                                                                                                     js/707.js │ 19.1 KiB │
└───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┴──────────┘
webpack compiled successfully

※ js/707.jsは @popperjs/core。Tempus Dominus Date/Time Pickerで使用

github actionsでテスト

wiki修正済み

レビュー完了希望日

なし

関連Pull requests/Issues

参考

DB変更の有無

無し

チェックリスト

@akagane99 akagane99 added the developer update 開発者向けの更新 label Mar 25, 2025
@akagane99 akagane99 self-assigned this Mar 25, 2025
@akagane99 akagane99 changed the title [日付入力] 日付入力ライブラリを tempusdominus-bootstrap-4 → @eonasdan/tempus-dominus v6に切替 [日付入力] 日付入力ライブラリを tempusdominus-bootstrap-4 → @eonasdan/tempus-dominus v6に切替 OW-2520 Mar 25, 2025
@akagane99 akagane99 marked this pull request as ready for review March 27, 2025 09:15
@akagane99 akagane99 requested a review from Copilot March 27, 2025 09:16
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the date input library from tempusdominus-bootstrap-4 to @eonasdan/tempus-dominus v6 to support newer features and maintain up‐to‐date dependencies.

  • Removed the old tempusdominus-bootstrap-4 require call.
  • Introduced the new @eonasdan/tempus-dominus library for date/time picker support.
Files not reviewed (19)
  • package.json: Language not supported
  • public/css/connect.css: Language not supported
  • public/js/app.js.LICENSE.txt: Language not supported
  • public/mix-manifest.json: Language not supported
  • resources/sass/app.scss: Language not supported
  • resources/views/core/cms_frame_edit.blade.php: Language not supported
  • resources/views/plugins/common/datetimepicker.blade.php: Language not supported
  • resources/views/plugins/manage/holiday/edit.blade.php: Language not supported
  • resources/views/plugins/manage/log/log.blade.php: Language not supported
  • resources/views/plugins/manage/reservation/bookings.blade.php: Language not supported
  • resources/views/plugins/manage/reservation/edit.blade.php: Language not supported
  • resources/views/plugins/user/blogs/default/blogs_input.blade.php: Language not supported
  • resources/views/plugins/user/blogs/default/blogs_list_categories.blade.php: Language not supported
  • resources/views/plugins/user/blogs/default/blogs_setting_frame.blade.php: Language not supported
  • resources/views/plugins/user/calendars/default/edit.blade.php: Language not supported
  • resources/views/plugins/user/databases/default/databases_input.blade.php: Language not supported
  • resources/views/plugins/user/databases/default/databases_input_date.blade.php: Language not supported
  • resources/views/plugins/user/databases/default/databases_input_time.blade.php: Language not supported
  • resources/views/plugins/user/faqs/default/faqs_input.blade.php: Language not supported
Comments suppressed due to low confidence (2)

resources/js/bootstrap.js:63

  • [nitpick] If the old library is no longer used, please remove the commented-out require statement to clean up the code.
// require('tempusdominus-bootstrap-4');

resources/js/bootstrap.js:67

  • [nitpick] Consider using a consistent import style (e.g. using ES module import) if the rest of the project follows that convention for module loading.
window.tempusDominus = require('@eonasdan/tempus-dominus');

@akagane99 akagane99 merged commit 3951020 into master Apr 1, 2025
1 check passed
@akagane99 akagane99 deleted the tempusdominus6 branch April 1, 2025 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

developer update 開発者向けの更新

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants