Skip to content

CMP+CRMF: fix formatting nits in sources and OSSL_CMP_ITAV_set0.pod#19230

Closed
DDvO wants to merge 2 commits into
openssl:masterfrom
siemens:CMP+CRMF_formatting_nits
Closed

CMP+CRMF: fix formatting nits in sources and OSSL_CMP_ITAV_set0.pod#19230
DDvO wants to merge 2 commits into
openssl:masterfrom
siemens:CMP+CRMF_formatting_nits

Conversation

@DDvO
Copy link
Copy Markdown
Contributor

@DDvO DDvO commented Sep 17, 2022

In addition, update example in OSSL_CMP_ITAV_set0.pod.

@DDvO DDvO added branch: master Applies to master branch approval: review pending This pull request needs review by a committer approval: otc review pending triaged: documentation The issue/pr deals with documentation (errors) triaged: refactor The issue/pr requests/implements refactoring labels Sep 17, 2022
@openssl-machine
Copy link
Copy Markdown
Collaborator

This PR is in a state where it requires action by @openssl/otc but the last update was 30 days ago

@openssl-machine
Copy link
Copy Markdown
Collaborator

This PR is in a state where it requires action by @openssl/otc but the last update was 61 days ago

@t8m t8m added tests: exempted The PR is exempt from requirements for testing and removed approval: otc review pending labels Nov 18, 2022
@DDvO
Copy link
Copy Markdown
Contributor Author

DDvO commented Nov 23, 2022

Thanks @t8m for the first approval.
Asking @openssl/committers for 2nd approval.

Copy link
Copy Markdown
Member

@beldmit beldmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beldmit beldmit added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Nov 23, 2022
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Nov 24, 2022
@openssl-machine
Copy link
Copy Markdown
Collaborator

This pull request is ready to merge

openssl-machine pushed a commit that referenced this pull request Nov 24, 2022
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com>
(Merged from #19230)
openssl-machine pushed a commit that referenced this pull request Nov 24, 2022
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com>
(Merged from #19230)
@DDvO
Copy link
Copy Markdown
Contributor Author

DDvO commented Nov 24, 2022

Merged - thanks @t8m and @beldmit

@DDvO DDvO closed this Nov 24, 2022
beldmit pushed a commit to beldmit/openssl that referenced this pull request Dec 26, 2022
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com>
(Merged from openssl#19230)
beldmit pushed a commit to beldmit/openssl that referenced this pull request Dec 26, 2022
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com>
(Merged from openssl#19230)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Applies to master branch tests: exempted The PR is exempt from requirements for testing triaged: documentation The issue/pr deals with documentation (errors) triaged: refactor The issue/pr requests/implements refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants