Skip to content

Return NULL from ossl_lib_ctx_get_concrete() when default_context_inited is set to false#26319

Closed
fwh-dc wants to merge 1 commit into
openssl:masterfrom
fwh-dc:fix-25442
Closed

Return NULL from ossl_lib_ctx_get_concrete() when default_context_inited is set to false#26319
fwh-dc wants to merge 1 commit into
openssl:masterfrom
fwh-dc:fix-25442

Conversation

@fwh-dc
Copy link
Copy Markdown
Contributor

@fwh-dc fwh-dc commented Jan 5, 2025

Fixes #25442

@github-actions github-actions Bot added the severity: fips change The pull request changes FIPS provider sources label Jan 5, 2025
@t8m t8m added branch: master Applies to master branch approval: review pending This pull request needs review by a committer triaged: bug The issue/pr is/fixes a bug branch: 3.0 Applies to openssl-3.0 branch branch: 3.1 Applies to openssl-3.1 (EOL) tests: exempted The PR is exempt from requirements for testing branch: 3.2 Applies to openssl-3.2 (EOL) branch: 3.3 Applies to openssl-3.3 (EOL) branch: 3.4 Applies to openssl-3.4 labels Jan 6, 2025
tom-cosgrove-arm
tom-cosgrove-arm approved these changes Jan 6, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@tom-cosgrove-arm tom-cosgrove-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tom-cosgrove-arm tom-cosgrove-arm added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Jan 6, 2025
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Jan 7, 2025
@openssl-machine
Copy link
Copy Markdown
Collaborator

openssl-machine commented Jan 7, 2025

This pull request is ready to merge

openssl-machine pushed a commit that referenced this pull request Jan 8, 2025
@fwh-dc @t8m
Return NULL from ossl_lib_ctx_get_concrete() when it is uninitialized
e997901 
When default_context_inited is set to false we return NULL instead of
the global default context.

Fixes #25442

Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #26319)

(cherry picked from commit dfce0d7)
openssl-machine pushed a commit that referenced this pull request Jan 8, 2025
@fwh-dc @t8m
Return NULL from ossl_lib_ctx_get_concrete() when it is uninitialized
dfce0d7 
When default_context_inited is set to false we return NULL instead of
the global default context.

Fixes #25442

Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #26319)
openssl-machine pushed a commit that referenced this pull request Jan 8, 2025
@fwh-dc @t8m
Return NULL from ossl_lib_ctx_get_concrete() when it is uninitialized
d220bf8 
When default_context_inited is set to false we return NULL instead of
the global default context.

Fixes #25442

Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #26319)

(cherry picked from commit dfce0d7)
openssl-machine pushed a commit that referenced this pull request Jan 8, 2025
@fwh-dc @t8m
Return NULL from ossl_lib_ctx_get_concrete() when it is uninitialized
193b94f 
When default_context_inited is set to false we return NULL instead of
the global default context.

Fixes #25442

Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #26319)

(cherry picked from commit dfce0d7)
openssl-machine pushed a commit that referenced this pull request Jan 8, 2025
@fwh-dc @t8m
Return NULL from ossl_lib_ctx_get_concrete() when it is uninitialized
ed7651c 
When default_context_inited is set to false we return NULL instead of
the global default context.

Fixes #25442

Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #26319)

(cherry picked from commit dfce0d7)
openssl-machine pushed a commit that referenced this pull request Jan 8, 2025
@fwh-dc @t8m
Return NULL from ossl_lib_ctx_get_concrete() when it is uninitialized
61217d1 
When default_context_inited is set to false we return NULL instead of
the global default context.

Fixes #25442

Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #26319)

(cherry picked from commit dfce0d7)
@t8m
Copy link
Copy Markdown
Member

t8m commented Jan 8, 2025

Merged to all the active branches with slightly tweaked commit message. Thank you for your contribution.

@t8m t8m closed this Jan 8, 2025
Sashan pushed a commit to Sashan/openssl that referenced this pull request Apr 23, 2025
@fwh-dc @Sashan
Return NULL from ossl_lib_ctx_get_concrete() when it is uninitialized
9fa5cc5 
When default_context_inited is set to false we return NULL instead of
the global default context.

Fixes openssl#25442

Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#26319)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@t8m t8m t8m approved these changes

@tom-cosgrove-arm tom-cosgrove-arm tom-cosgrove-arm approved these changes

Assignees

No one assigned

Labels

approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Applies to master branch branch: 3.0 Applies to openssl-3.0 branch branch: 3.1 Applies to openssl-3.1 (EOL) branch: 3.2 Applies to openssl-3.2 (EOL) branch: 3.3 Applies to openssl-3.3 (EOL) branch: 3.4 Applies to openssl-3.4 severity: fips change The pull request changes FIPS provider sources tests: exempted The PR is exempt from requirements for testing triaged: bug The issue/pr is/fixes a bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

When failed to initialize default_context_int, CRYPTO_THREAD_read_lock function will cause a crash.

4 participants

@fwh-dc @openssl-machine @t8m @tom-cosgrove-arm