Skip to content

coveralls.yml: Avoid excluding subdirectories of already excluded dirs#26405

Closed
t8m wants to merge 1 commit into
openssl:masterfrom
t8m:coveralls-ignore-errors-2
Closed

coveralls.yml: Avoid excluding subdirectories of already excluded dirs#26405
t8m wants to merge 1 commit into
openssl:masterfrom
t8m:coveralls-ignore-errors-2

Conversation

@t8m
Copy link
Copy Markdown
Member

@t8m t8m commented Jan 13, 2025

This is again urgent due to Coverage CI failure.

@t8m t8m added branch: master Applies to master branch approval: review pending This pull request needs review by a committer triaged: bug The issue/pr is/fixes a bug severity: urgent Fixes an urgent issue (exempt from 24h grace period) tests: exempted The PR is exempt from requirements for testing labels Jan 13, 2025
@mattcaswell
Copy link
Copy Markdown
Member

Agree urgent

@t8m t8m requested a review from a team January 13, 2025 13:32
Copy link
Copy Markdown
Contributor

@Sashan Sashan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is urgent.

@t8m t8m added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Jan 13, 2025
@t8m
Copy link
Copy Markdown
Member Author

t8m commented Jan 13, 2025

Merged to the master branch. Thank you for the reviews.

@t8m t8m closed this Jan 13, 2025
openssl-machine pushed a commit that referenced this pull request Jan 13, 2025
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Saša Nedvědický <sashan@openssl.org>
(Merged from #26405)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval: done This pull request has the required number of approvals branch: master Applies to master branch severity: urgent Fixes an urgent issue (exempt from 24h grace period) tests: exempted The PR is exempt from requirements for testing triaged: bug The issue/pr is/fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants