Fix a switch statement fallthrough #4888
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SSL_trace() has a case which was inadvertently falling through.
mattcaswell
added
branch: 1.0.2
levitte
approved these changes
Dec 10, 2017
richsalz
approved these changes
Dec 10, 2017
levitte
pushed a commit
that referenced
this pull request
Dec 11, 2017
SSL_trace() has a case which was inadvertently falling through. Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from #4888)
Member
Author
|
Pushed. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSL_trace() has a case which was inadvertently falling through.
My compiler was complaining about this fall through. The same problem exists in 1.0.2 but for some reason that I don't understand my compiler isn't complaining about that one - but we should fix it anyway. The cherry-pick isn't entirely clean but it is trivial to resolve. This doesn't affect the master branch.
Checklist