conn_is_closed should return 1 if get_last_sys_error is WSAECONNRESET #8590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openssl-machine
added
the
hold: cla required
This was referenced Mar 26, 2019
mattcaswell
added
branch: master
Member
|
@paulmon please can you amend your commit message to include the "CLA: trivial" text in the commit description (to keep the CLA bot happy). |
mattcaswell
added
the
approval: review pending
paulmon
changed the title
paulmon
changed the title
Contributor
Author
|
I tried editing the commit message with git --amend, but the buildbot still doesn't like it. |
Member
|
Close/reopen to kick CLA bot |
mattcaswell
removed
the
hold: cla required
Member
|
Not sure why the bot doesn't like it. It looks ok to me. I removed it by hand for now. |
paulidale
approved these changes
Mar 28, 2019
Contributor
paulidale
left a comment
paulidale
left a comment
There was a problem hiding this comment.
Agree that this is trivial.
paulidale
added
approval: done
levitte
pushed a commit
that referenced
this pull request
Mar 28, 2019
CLA: trivial Reviewed-by: Paul Dale <paul.dale@oracle.com> Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from #8590)
Member
|
Pushed. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLA: trivial
conn_is_closed should check for WSAECONNRESET on Windows because it has a different value than ECONNRESET. Without this check ssl tests fail in the Python standard tests because the SSL_do_handshake() on the server side returns an error if the client closes the socket too quickly.