Conversation
- trim trailing line breaks, as those are making keys invalid. - raise explicit exception when no usable keys has been found. - log warning when a key file was not considered usable. Irrelevant: make config.auth section mandatory Since without specifying auth.methods the whole thing is not able to work make the section non-default.
|
Bencher Report| Branch | fernet |
| Testbed | ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result microseconds (µs) (Result Δ%) | Upper Boundary microseconds (µs) (Limit %) |
|---|---|---|---|
| fernet token/project | 📈 view plot 🚷 view threshold | 1.15 µs(-50.49%)Baseline: 2.33 µs | 9.69 µs (11.91%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Irrelevant: make config.auth section mandatory
Since without specifying auth.methods the whole thing is not able to
work make the section non-default.