Skip to content

feat: Forbid use of unwrap and expect#347

Merged
gtema merged 1 commit intomainfrom
unsafe
Nov 7, 2025
Merged

feat: Forbid use of unwrap and expect#347
gtema merged 1 commit intomainfrom
unsafe

Conversation

@gtema
Copy link
Collaborator

@gtema gtema commented Nov 7, 2025

Add a linter rule forbidding use of unwrap and expect in the code. Of
course this required adding corresponding handling of potential errors.

Fixes: #329

Add a linter rule forbidding use of unwrap and expect in the code. Of
course this required adding corresponding handling of potential errors.

Fixes: #329
@github-actions
Copy link

github-actions bot commented Nov 7, 2025

🐰 Bencher Report

Branchunsafe
Testbedubuntu-latest
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
microseconds (µs)
(Result Δ%)
Upper Boundary
microseconds (µs)
(Limit %)
fernet token/project📈 view plot
🚷 view threshold
1.14 µs
(+1.20%)Baseline: 1.13 µs
1.23 µs
(92.67%)
🐰 View full continuous benchmarking report in Bencher

@github-actions
Copy link

github-actions bot commented Nov 7, 2025

🦢 Load Test Results

Goose Attack Report

Plan Overview

Action Started Stopped Elapsed Users
Increasing 25-11-07 18:39:56 25-11-07 18:39:58 00:00:02 0 → 4
Maintaining 25-11-07 18:39:58 25-11-07 18:40:28 00:00:30 4
Decreasing 25-11-07 18:40:28 25-11-07 18:40:28 00:00:00 0 ← 4

Request Metrics

Method Name # Requests # Fails Average (ms) Min (ms) Max (ms) RPS Failures/s
GET 15864 0 7.06 5 14 528.80 0.00
Aggregated 15864 0 7.06 5 14 528.80 0.00

Response Time Metrics

Method Name 50%ile (ms) 60%ile (ms) 70%ile (ms) 80%ile (ms) 90%ile (ms) 95%ile (ms) 99%ile (ms) 100%ile (ms)
GET 7 7 7 7 8 8 9 14
Aggregated 7 7 7 7 8 8 9 14

Status Code Metrics

Method Name Status Codes
GET 15,864 [200]
Aggregated 15,864 [200]

Transaction Metrics

Transaction # Times Run # Fails Average (ms) Min (ms) Max (ms) RPS Failures/s
ListUsers
0.0 0 0 0.00 0 0 0.00 0.00
0.1 15864 0 7.08 5 14 528.80 0.00
Aggregated 15864 0 7.06 5 14 528.80 0.00

Scenario Metrics

Transaction # Users # Times Run Average (ms) Min (ms) Max (ms) Scenarios/s Iterations
ListUsers 4 15860 7.08 5 14 528.67 3965.00
Aggregated 4 15860 7.08 5 14 528.67 3965.00

Error Metrics

Method Name # Error

View full report

@gtema gtema self-assigned this Nov 7, 2025
@gtema gtema added this to Keystone Nov 7, 2025
@github-project-automation github-project-automation bot moved this to Backlog in Keystone Nov 7, 2025
@gtema gtema moved this from Backlog to Ready in Keystone Nov 7, 2025
@gtema gtema moved this from Ready to In review in Keystone Nov 7, 2025
@gtema gtema merged commit 754c343 into main Nov 7, 2025
25 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in Keystone Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

API Panic Vulnerabilities via unwrap() Misuse

1 participant

Comments