refactor: Start passing ServiceState into providers#366
Merged
Conversation
|
Bencher Report| Branch | pass_state |
| Testbed | ubuntu-latest |
🚨 1 Alert
| Benchmark | Measure Units | View | Benchmark Result (Result Δ%) | Upper Boundary (Limit %) |
|---|---|---|---|---|
| fernet token/project | Latency microseconds (µs) | 📈 plot 🚷 threshold 🚨 alert (🔔) | 1.49 µs(+27.03%)Baseline: 1.18 µs | 1.44 µs (103.42%) |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Upper Boundary nanoseconds (ns) (Limit %) |
|---|---|---|---|
| fernet token/project | 📈 view plot 🚷 view threshold 🚨 view alert (🔔) | 1,493.20 ns(+27.03%)Baseline: 1,175.47 ns | 1,443.79 ns (103.42%) |
| get_fernet_token_timestamp/project | 📈 view plot 🚷 view threshold | 162.09 ns(+4.65%)Baseline: 154.89 ns | 186.36 ns (86.98%) |
|
🦢 Load Test Results Goose Attack ReportPlan Overview
Request Metrics
Response Time Metrics
Status Code Metrics
Transaction Metrics
Scenario Metrics
Error Metrics
|
In order to make providers easier it makes much more sense to pass the overall app state instead of database connection and provider manager. This way every backend is able to extract only the information it really needs and we do not need to extend methods once we figure out that we need to pass something else.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to make providers easier it makes much more sense to pass the
overall app state instead of database connection and provider manager.
This way every backend is able to extract only the information it really
needs and we do not need to extend methods once we figure out that we
need to pass something else.