Skip to content

feat: Add explicit target type in assignments#416

Merged
gtema merged 1 commit intomainfrom
identity
Dec 2, 2025
Merged

feat: Add explicit target type in assignments#416
gtema merged 1 commit intomainfrom
identity

Conversation

@gtema
Copy link
Collaborator

@gtema gtema commented Dec 2, 2025

Before we add querying system role assignments we need a way to clearly
differentiate what resource is the target_id actually is pointing at.
Add a type field to the structure and extend all of the structures with
the validations.

@github-actions
Copy link

github-actions bot commented Dec 2, 2025

🐰 Bencher Report

Branchidentity
Testbedubuntu-latest
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)
Upper Boundary
nanoseconds (ns)
(Limit %)
fernet token/project📈 view plot
🚷 view threshold
1,458.70 ns
(+11.52%)Baseline: 1,307.99 ns
1,676.56 ns
(87.01%)
get_fernet_token_timestamp/project📈 view plot
🚷 view threshold
141.37 ns
(-9.34%)Baseline: 155.94 ns
205.11 ns
(68.92%)
🐰 View full continuous benchmarking report in Bencher

@github-actions
Copy link

github-actions bot commented Dec 2, 2025

🦢 Load Test Results

Goose Attack Report

Plan Overview

Action Started Stopped Elapsed Users
Increasing 25-12-02 16:14:36 25-12-02 16:14:38 00:00:02 0 → 4
Maintaining 25-12-02 16:14:38 25-12-02 16:15:08 00:00:30 4
Decreasing 25-12-02 16:15:08 25-12-02 16:15:08 00:00:00 0 ← 4

Request Metrics

Method Name # Requests # Fails Average (ms) Min (ms) Max (ms) RPS Failures/s
GET 9549 0 12.07 7 26 318.30 0.00
Aggregated 9549 0 12.07 7 26 318.30 0.00

Response Time Metrics

Method Name 50%ile (ms) 60%ile (ms) 70%ile (ms) 80%ile (ms) 90%ile (ms) 95%ile (ms) 99%ile (ms) 100%ile (ms)
GET 10 11 16 16 17 17 19 26
Aggregated 10 11 16 16 17 17 19 26

Status Code Metrics

Method Name Status Codes
GET 9,549 [200]
Aggregated 9,549 [200]

Transaction Metrics

Transaction # Times Run # Fails Average (ms) Min (ms) Max (ms) RPS Failures/s
ListUsers
0.0 0 0 0.00 0 0 0.00 0.00
0.1 6041 0 9.45 7 15 201.37 0.00
ValidateToken
1.0 0 0 0.00 0 0 0.00 0.00
1.1 3508 0 16.65 13 26 116.93 0.00
Aggregated 9549 0 12.07 7 26 318.30 0.00

Scenario Metrics

Transaction # Users # Times Run Average (ms) Min (ms) Max (ms) Scenarios/s Iterations
ListUsers 2 6039 9.45 7 15 201.30 3019.50
ValidateToken 2 3506 16.65 14 26 116.87 1753.00
Aggregated 4 9545 12.10 7 26 318.17 4772.50

Error Metrics

Method Name # Error

View full report

Before we add querying system role assignments we need a way to clearly
differentiate what resource is the target_id actually is pointing at.
Add a type field to the structure and extend all of the structures with
the validations.
@gtema gtema merged commit 9a3c30a into main Dec 2, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments