feat: Include system assignments in the list_for_multiple_actors_and_targets method#426
Conversation
|
@gtema |
|
You could have just squashed and rewritten commits, but it's ok. I know that certain workflows require elevated privileges and cannot be executed from forks, but I don't know how to deal with that so far |
1 similar comment
|
You could have just squashed and rewritten commits, but it's ok. I know that certain workflows require elevated privileges and cannot be executed from forks, but I don't know how to deal with that so far |
I have tried to create new branch from remote repo but remote branch permissions prevent changes on repository. I don't know how to pass tests. |
gtema
force-pushed
the
fix/system-assignments-issue-143-clean
branch
from
bb3392a to
dcc480b
Compare
Include system role assignments in the `list_for_multiple_actors_and_targets` method. Closes: openstack-experimental#143
gtema
force-pushed
the
fix/system-assignments-issue-143-clean
branch
from
dcc480b to
1c6ce57
Compare
gtema
changed the title
list_for_multiple_actors_and_targets method
| .add_option( | ||
| target | ||
| .inherited | ||
| .map(|x| db_assignment::Column::Inherited.eq(x)), |
There was a problem hiding this comment.
@gtema
I am not sure but there might be a bug in here. during add_option you are using db_assignment but shouldn't it to be db_system_assignment?
There was a problem hiding this comment.
Oh yes, you are right. Can you pls make a quick PR for that?
2 participants
Include system role assignments in the
list_for_multiple_actors_and_targetsmethod.