Add logging to a file for os must gather task#3246
Merged
amartyasinha merged 1 commit intoopenstack-k8s-operators:mainfrom Sep 4, 2025
Merged
Add logging to a file for os must gather task#3246amartyasinha merged 1 commit intoopenstack-k8s-operators:mainfrom
amartyasinha merged 1 commit intoopenstack-k8s-operators:mainfrom
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
danpawlik
force-pushed
the
improve-logging
branch
from
c5413df to
70c64b4
Compare
After we drop executing Ansible playbook and we move temporary to Ansible command directly, there is an issue that some tasks are not executed properly. Add ANSIBLE_LOG_PATH for that task for now, to make clear view what is executed. Signed-off-by: Daniel Pawlik <dpawlik@redhat.com>
danpawlik
force-pushed
the
improve-logging
branch
from
70c64b4 to
d0282a0
Compare
danpawlik
requested review from
Valkyrie00,
amartyasinha,
brjackma,
bshewale and
michburk
amartyasinha
reviewed
Sep 3, 2025
Contributor
|
lgtm :) |
amartyasinha
approved these changes
Sep 4, 2025
cescgina
approved these changes
Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After we drop executing Ansible playbook and we move temporary to Ansible command directly, there is an issue that some tasks are not executed properly.
Add ANSIBLE_LOG_PATH for that task for now, to make clear view what is executed.