Remove read_global_vars pre-task from jobs#3332
Merged
amartyasinha merged 1 commit intoopenstack-k8s-operators:mainfrom Sep 30, 2025
Merged
Conversation
The reason to remove the playbook from pre-run stage from Zuul is, Zuul is not storing the cached vars that we added in pre-run. Maybe it is possible by some other way, but lets remove this for now.
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
evallesp
approved these changes
Sep 25, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
|
recheck |
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
|
recheck |
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
|
recheck |
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
|
recheck |
danpawlik
approved these changes
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reason to remove the playbook from pre-run stage from Zuul is, Zuul is not storing the cached vars that we added in pre-run. Maybe it is possible by some other way, but lets remove this for now.
Creating a manual patch instead of revert as this task was done in multiple PR, and might require revert for each PR.
Reverting: #3258, #3276, #3277, #3278, #3279
Depends-On: #3346