Ensure molecule finds group_vars#3333
Merged
amartyasinha merged 1 commit intoopenstack-k8s-operators:mainfrom Oct 1, 2025
Merged
Ensure molecule finds group_vars#3333amartyasinha merged 1 commit intoopenstack-k8s-operators:mainfrom
amartyasinha merged 1 commit intoopenstack-k8s-operators:mainfrom
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
amartyasinha
force-pushed
the
make_molecule_read
branch
from
90892d4 to
3404190
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
|
recheck |
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
|
recheck |
This comment was marked as outdated.
This comment was marked as outdated.
amartyasinha
force-pushed
the
make_molecule_read
branch
from
3404190 to
d43ab3a
Compare
amartyasinha
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
amartyasinha
force-pushed
the
make_molecule_read
branch
from
d43ab3a to
65e7669
Compare
This comment was marked as outdated.
This comment was marked as outdated.
amartyasinha
force-pushed
the
make_molecule_read
branch
4 times, most recently
from
cee872d to
565b011
Compare
Molecule can also use group_vars. For that, we have to add the path to group_vars dir in molecule config. This commit adds the path. It should be noted that relative path from config file wont work. Since molecule will expand the relative path during the molecule test run, the path to group_vars dir should be relative with molecule jobs from where they are run. More details will be in the PR
amartyasinha
force-pushed
the
make_molecule_read
branch
from
565b011 to
b461fc7
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
|
recheck |
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
|
recheck |
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
|
recheck |
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
|
recheck |
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
|
recheck |
Contributor
Author
|
recheck |
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
|
recheck |
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
|
recheck |
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
|
recheck |
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
|
recheck |
|
This change depends on a change that failed to merge. Change #3352 is needed. |
Contributor
Author
|
recheck |
|
This change depends on a change that failed to merge. Change #3352 is needed. |
Contributor
Author
|
recheck |
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
|
recheck |
amartyasinha
changed the title
Valkyrie00
approved these changes
Oct 1, 2025
amartyasinha
added a commit
to amartyasinha/ci-framework
that referenced
this pull request
Oct 1, 2025
…status/molecule.yml PR [1] ensured our molecule jobs can use group_vars. During this, adding molecule group to one file was missed. This commit adds that. [1] openstack-k8s-operators#3333
amartyasinha
added a commit
that referenced
this pull request
Oct 1, 2025
…status/molecule.yml PR [1] ensured our molecule jobs can use group_vars. During this, adding molecule group to one file was missed. This commit adds that. [1] #3333
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Molecule can also use group_vars. For that, we have to add the path to group_vars dir in molecule config. This commit adds the path. It should be noted that relative path from config file wont work. Since molecule will expand the relative path during the molecule test run, the path to group_vars dir should be relative with molecule jobs from where they are run. More details will be in the PR.
Molecule is loading and using the group_vars. One of the examples of passing job is here 1. In this job, molecule used the config file, and also read the group_vars. Before adding the group_vars, the molecule test was failing with undefined var. But the moment it was added, it passed. There is one failure at the playbook executed by zuul-executor, but that failure is independent of this specific change, and that will be fixed in another patch. More details in 2.
Depends-On: #3353