Increase the scope of cifmw-pods-zuul-files job#3355
Merged
amartyasinha merged 1 commit intoopenstack-k8s-operators:mainfrom Sep 30, 2025
Merged
Conversation
Just checking the changes to molecule files solve only half of our problem. If a user add a new role, even then molecule job definition for that role is not added, and this job starts to fail in future. Though running this job on any change made in roles dir is quite wider scope. But seems like it is not possible to just run the job when new role is added.
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
danpawlik
approved these changes
Sep 30, 2025
Contributor
|
why not. Better to be sure. |
Contributor
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just checking the changes to molecule files solve only half of our problem. If a user add a new role, even then molecule job definition for that role is not added, and this job starts to fail in future. Though running this job on any change made in roles dir is quite wider scope. But seems like it is not possible to just run the job when new role is added.
Related to: #3348