Add loop_var in cifmw_helpers task files; trim vars in helper; improve finding files in var_dir#3404
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
danpawlik
force-pushed
the
add-loop-var
branch
from
377bb94 to
c3fe2cf
Compare
danpawlik
changed the title
danpawlik
force-pushed
the
add-loop-var
branch
from
c3fe2cf to
9ad8dd8
Compare
danpawlik
requested review from
Valkyrie00,
amartyasinha,
brjackma,
dasm,
evallesp,
michburk and
sdatko
danpawlik
changed the title
danpawlik
force-pushed
the
add-loop-var
branch
from
9ad8dd8 to
9f142a3
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/fce2027e029c40b9aaeccdeaa231d5b3 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 46m 04s |
Depends-On: openstack-k8s-operators#3404 Depends-On: openstack-k8s-operators#3406 Co-Authored-By: Daniel Pawlik <dpawlik@redhat.com> Signed-off-by: Daniel Pawlik <dpawlik@redhat.com>
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f2b86410838c45c0b3147c34543ada4c ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 42m 19s |
danpawlik
force-pushed
the
add-loop-var
branch
from
9f142a3 to
c53ba61
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/0b19a64072e64915b2b29e515056a399 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 59m 28s |
|
recheck |
To avoid unecessary conflicts issue where "item" was already used in higher task, let's add loop_var to have better control on the vars what are parsed. Also trim variables in var_dir and var_file and improve finding files to parse in var_dir helper. Signed-off-by: Daniel Pawlik <dpawlik@redhat.com>
danpawlik
force-pushed
the
add-loop-var
branch
from
c53ba61 to
3c9a9aa
Compare
The cifmw_helpers role does not have molecule job, would be good to verify if it always returns correct result. Depends-On: openstack-k8s-operators#3404 Signed-off-by: Daniel Pawlik <dpawlik@redhat.com>
The cifmw_helpers role does not have molecule job, would be good to verify if it always returns correct result. Depends-On: #3404 Signed-off-by: Daniel Pawlik <dpawlik@redhat.com>
3 participants
To avoid unecessary conflicts issue where "item" was already used in higher task, let's add loop_var to have better control on the vars what are parsed.
Also trim variables in var_dir and var_file and improve finding files
to parse in var_dir helper.
Depends-On: #3410