Skip to content

[multiple] Consolidate openstack ns var: cifmw_openstack_namespace#3533

Merged
brjackma merged 1 commit intoopenstack-k8s-operators:mainfrom
amartyasinha:ns_group_vars
Jan 6, 2026
Merged

[multiple] Consolidate openstack ns var: cifmw_openstack_namespace#3533
brjackma merged 1 commit intoopenstack-k8s-operators:mainfrom
amartyasinha:ns_group_vars

Conversation

@amartyasinha
Copy link
Copy Markdown
Contributor

@amartyasinha amartyasinha commented Dec 4, 2025 •
edited
Loading

There are multiple variables related to openstack namespace in OCP. This commit tries to consolidate them all with a single variable defined in group_vars. At some places, ns var were being read from cifmw_install_yamls_defaults and they are left unchanged.

Depends-On: #3534

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 4, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 4, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign eshulman2 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@softwarefactory-project-zuul
Copy link
Copy Markdown

softwarefactory-project-zuul Bot commented Dec 4, 2025

This change depends on a change that failed to merge.

Change #3534 is needed.

@amartyasinha
Copy link
Copy Markdown
Contributor Author

amartyasinha commented Dec 4, 2025

recheck

@amartyasinha amartyasinha force-pushed the ns_group_vars branch 4 times, most recently from 5370e51 to fb7bc49 Compare December 5, 2025 10:25
@amartyasinha amartyasinha changed the title Consolidate openstack ns var: cifmw_openstack_namespace [multiple] Consolidate openstack ns var: cifmw_openstack_namespace Dec 5, 2025
@softwarefactory-project-zuul
Copy link
Copy Markdown

softwarefactory-project-zuul Bot commented Dec 5, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/02bc83d383a24416a924281cfc3d342d

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 19m 14s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 26m 21s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 38m 33s
✔️ cifmw-crc-podified-edpm-baremetal-minor-update SUCCESS in 1h 58m 06s
❌ podified-multinode-hci-deployment-crc RETRY_LIMIT in 10m 28s
✔️ cifmw-multinode-tempest SUCCESS in 1h 47m 54s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 36s
✔️ adoption-standalone-to-crc-ceph-provider SUCCESS in 3h 04m 25s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 28s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 21s
✔️ build-push-container-cifmw-client SUCCESS in 16m 32s
✔️ cifmw-molecule-ci_dcn_site SUCCESS in 2m 17s
✔️ cifmw-molecule-ci_multus SUCCESS in 25m 34s
✔️ cifmw-molecule-cifmw_cephadm SUCCESS in 4m 38s
✔️ cifmw-molecule-cifmw_setup SUCCESS in 2m 15s
✔️ cifmw-molecule-cleanup_openstack SUCCESS in 2m 33s
✔️ cifmw-molecule-federation SUCCESS in 2m 21s
✔️ cifmw-molecule-install_openstack_ca SUCCESS in 27m 12s
✔️ cifmw-molecule-manage_secrets SUCCESS in 20m 08s
✔️ cifmw-molecule-os_must_gather SUCCESS in 24m 21s
✔️ cifmw-molecule-run_hook SUCCESS in 3m 47s
✔️ cifmw-molecule-shiftstack SUCCESS in 17m 06s
✔️ cifmw-molecule-tempest SUCCESS in 4m 54s
✔️ cifmw-molecule-test_operator SUCCESS in 3m 19s
✔️ cifmw-molecule-update SUCCESS in 4m 59s

@amartyasinha
Copy link
Copy Markdown
Contributor Author

amartyasinha commented Dec 8, 2025

recheck

@softwarefactory-project-zuul
Copy link
Copy Markdown

softwarefactory-project-zuul Bot commented Dec 8, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/7743ca00aaf047eb8e7c2f80225de5cc

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 23m 50s
❌ podified-multinode-edpm-deployment-crc RETRY_LIMIT in 9m 23s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 26m 40s
❌ cifmw-crc-podified-edpm-baremetal-minor-update RETRY_LIMIT in 20m 33s
✔️ podified-multinode-hci-deployment-crc SUCCESS in 1h 44m 48s
❌ cifmw-multinode-tempest RETRY_LIMIT in 9m 05s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 32s
✔️ adoption-standalone-to-crc-ceph-provider SUCCESS in 3h 10m 46s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 38s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 40s
✔️ build-push-container-cifmw-client SUCCESS in 19m 13s
✔️ cifmw-molecule-ci_dcn_site SUCCESS in 2m 23s
✔️ cifmw-molecule-ci_multus SUCCESS in 26m 16s
✔️ cifmw-molecule-cifmw_cephadm SUCCESS in 4m 52s
✔️ cifmw-molecule-cifmw_setup SUCCESS in 2m 18s
✔️ cifmw-molecule-cleanup_openstack SUCCESS in 2m 26s
✔️ cifmw-molecule-federation SUCCESS in 2m 31s
❌ cifmw-molecule-install_openstack_ca RETRY_LIMIT in 8m 55s
✔️ cifmw-molecule-manage_secrets SUCCESS in 19m 34s
✔️ cifmw-molecule-os_must_gather SUCCESS in 26m 08s
✔️ cifmw-molecule-run_hook SUCCESS in 3m 41s
✔️ cifmw-molecule-shiftstack SUCCESS in 12m 29s
✔️ cifmw-molecule-tempest SUCCESS in 5m 15s
✔️ cifmw-molecule-test_operator SUCCESS in 3m 37s
✔️ cifmw-molecule-update SUCCESS in 5m 20s

@amartyasinha
Copy link
Copy Markdown
Contributor Author

amartyasinha commented Dec 9, 2025

recheck

@softwarefactory-project-zuul
Copy link
Copy Markdown

softwarefactory-project-zuul Bot commented Dec 9, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/453a5192091248b59f5f3f69f692cf90

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 16m 34s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 20m 34s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 35m 56s
✔️ cifmw-crc-podified-edpm-baremetal-minor-update SUCCESS in 2h 04m 45s
❌ podified-multinode-hci-deployment-crc RETRY_LIMIT in 10m 28s
✔️ cifmw-multinode-tempest SUCCESS in 1h 56m 03s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 33s
✔️ adoption-standalone-to-crc-ceph-provider SUCCESS in 2h 59m 47s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 59s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 20s
✔️ build-push-container-cifmw-client SUCCESS in 17m 37s
✔️ cifmw-molecule-ci_dcn_site SUCCESS in 2m 21s
✔️ cifmw-molecule-ci_multus SUCCESS in 20m 30s
✔️ cifmw-molecule-cifmw_cephadm SUCCESS in 4m 32s
✔️ cifmw-molecule-cifmw_setup SUCCESS in 2m 18s
✔️ cifmw-molecule-cleanup_openstack SUCCESS in 2m 16s
✔️ cifmw-molecule-federation SUCCESS in 2m 21s
✔️ cifmw-molecule-install_openstack_ca SUCCESS in 29m 50s
✔️ cifmw-molecule-manage_secrets SUCCESS in 16m 31s
✔️ cifmw-molecule-os_must_gather SUCCESS in 26m 04s
✔️ cifmw-molecule-run_hook SUCCESS in 3m 41s
✔️ cifmw-molecule-shiftstack SUCCESS in 12m 47s
✔️ cifmw-molecule-tempest SUCCESS in 5m 02s
✔️ cifmw-molecule-test_operator SUCCESS in 3m 22s
✔️ cifmw-molecule-update SUCCESS in 5m 01s

@amartyasinha
Copy link
Copy Markdown
Contributor Author

amartyasinha commented Dec 9, 2025

recheck

@softwarefactory-project-zuul
Copy link
Copy Markdown

softwarefactory-project-zuul Bot commented Dec 9, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/42974ddf18d642aab22958b8bf509732

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 32m 47s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 24m 02s
❌ cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 12m 48s
❌ cifmw-crc-podified-edpm-baremetal-minor-update FAILURE in 1h 40m 27s
❌ podified-multinode-hci-deployment-crc RETRY_LIMIT in 10m 48s
✔️ cifmw-multinode-tempest SUCCESS in 1h 45m 22s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 17s
✔️ adoption-standalone-to-crc-ceph-provider SUCCESS in 3h 17m 12s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 29s
✔️ cifmw-pod-pre-commit SUCCESS in 9m 27s
✔️ build-push-container-cifmw-client SUCCESS in 19m 06s
✔️ cifmw-molecule-ci_dcn_site SUCCESS in 2m 21s
✔️ cifmw-molecule-ci_multus SUCCESS in 24m 09s
✔️ cifmw-molecule-cifmw_cephadm SUCCESS in 4m 44s
✔️ cifmw-molecule-cifmw_setup SUCCESS in 2m 24s
✔️ cifmw-molecule-cleanup_openstack SUCCESS in 2m 16s
✔️ cifmw-molecule-federation SUCCESS in 2m 23s
❌ cifmw-molecule-install_openstack_ca RETRY_LIMIT in 8m 01s
✔️ cifmw-molecule-manage_secrets SUCCESS in 19m 00s
✔️ cifmw-molecule-os_must_gather SUCCESS in 24m 10s
✔️ cifmw-molecule-run_hook SUCCESS in 3m 46s
✔️ cifmw-molecule-shiftstack SUCCESS in 15m 04s
✔️ cifmw-molecule-tempest SUCCESS in 4m 56s
✔️ cifmw-molecule-test_operator SUCCESS in 3m 29s
✔️ cifmw-molecule-update SUCCESS in 4m 53s

@amartyasinha
Copy link
Copy Markdown
Contributor Author

amartyasinha commented Dec 10, 2025

recheck

@amartyasinha
[multiple] Consolidate openstack ns var: cifmw_openstack_namespace
ee3f29a 
There are multiple variables related to openstack namespace in OCP. This commit tries to consolidate them all with a single variable defined in group_vars. At some places, ns var were being read from cifmw_install_yamls_defaults, thus it is being used as the value for cifmw_openstack_namespace var in group_vars along with default value of openstack.

Signed-off-by: Amartya Sinha <amsinha@redhat.com>
@amartyasinha amartyasinha marked this pull request as ready for review December 29, 2025 05:38
@amartyasinha amartyasinha requested a review from a team January 6, 2026 09:33
brjackma
brjackma approved these changes Jan 6, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@brjackma brjackma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, all tests passing and changes make sense. Approved

@brjackma brjackma merged commit a80e1be into openstack-k8s-operators:main Jan 6, 2026
8 of 10 checks passed
@amartyasinha amartyasinha deleted the ns_group_vars branch January 6, 2026 09:47
@xek xek mentioned this pull request Feb 5, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evallesp evallesp evallesp approved these changes

@brjackma brjackma brjackma approved these changes

Assignees

No one assigned

Labels

Ready For Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@amartyasinha @evallesp @brjackma