Skip to content

[disconnected] Create hook to configure disconnected cluster#3814

Draft
drosenfe wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
drosenfe:disconnectedhook
Draft

[disconnected] Create hook to configure disconnected cluster#3814
drosenfe wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
drosenfe:disconnectedhook

Conversation

@drosenfe
Copy link
Copy Markdown
Contributor

Create a hook to configure openshift cluster for disconnected deployment. The hook should execute after the cluster is deployed but before openstack is deployed.

Signed-off-by: David Rosenfeld drosenfe@redhat.com

@drosenfe drosenfe marked this pull request as draft March 30, 2026 14:02
@softwarefactory-project-zuul
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/3bfbd3399c6a4ba885dea99111ee34ba

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 13m 20s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 24m 06s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 30m 46s
✔️ cifmw-crc-podified-edpm-baremetal-minor-update SUCCESS in 2h 00m 26s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 48s
cifmw-pod-pre-commit FAILURE in 8m 03s

Comment thread hooks/playbooks/config_cluster_for_disconnected_deployment.yml Outdated
Comment thread hooks/playbooks/config_cluster_for_disconnected_deployment.yml Outdated
Comment thread hooks/playbooks/config_cluster_for_disconnected_deployment.yml Outdated
Comment thread hooks/playbooks/config_cluster_for_disconnected_deployment.yml Outdated
Comment thread hooks/playbooks/config_cluster_for_disconnected_deployment.yml Outdated
Comment thread hooks/playbooks/config_cluster_for_disconnected_deployment.yml Outdated
Comment thread hooks/playbooks/config_cluster_for_disconnected_deployment.yml Outdated
Comment thread hooks/playbooks/config_cluster_for_disconnected_deployment.yml Outdated
Comment thread hooks/playbooks/config_cluster_for_disconnected_deployment.yml Outdated
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 10, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign dasm for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@softwarefactory-project-zuul
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a9418611826d43ccbda9dbdbbe8f99a3

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 10m 37s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 25m 30s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 28m 26s
✔️ cifmw-crc-podified-edpm-baremetal-minor-update SUCCESS in 1h 57m 28s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 13s
cifmw-pod-pre-commit FAILURE in 8m 01s

Copy link
Copy Markdown
Contributor

@slagle slagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you'll also need another task to login the dataplane nodes to the mirror registry. you can add this to edpm_container_registry_logins somewhere.

packages:
- name: openstack-operator
- name: kubernetes-nmstate-operator
- name: openshift-cert-manager-operator
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cert-manager-operator needs to be listed with a different catalog like so:

kind: ImageSetConfiguration
apiVersion: mirror.openshift.io/v2alpha1
mirror:
  operators:
    - catalog: {{ oc_mirror_catalog_url }}
      packages:
       - name: openstack-operator
       - name: kubernetes-nmstate-operator
       - name: openshift-cert-manager-operator
       - name: metallb-operator
       - name: local-storage-operator
       - name: lvms-operator
       - name: cluster-observability-operator
    - catalog: {{ oc_mirror_cert_manager_catalog_url }}
      packages:
       - name: openshift-cert-manager-operator
  additionalImages:
   - name: registry.redhat.io/ubi8/ubi:latest
   - name: registry.redhat.io/ubi9/ubi@sha256:20f695d2a91352d4eaa25107535126727b5945bff38ed36a3e59590f495046f0

I've used a separate var for the catalog source for openshift-cert-manager-operator, {{ oc_mirror_cert_manager_catalog_url }}, which should default to registry.redhat.io/redhat/redhat-operator-index:v4.18
This is because the cert-manager operator is not included in our index image we use in CI.

After using this ImageSetConfiguration you'll end up with CatalogSources generated for both sources:

[stack@host05 disconnected]$ ls -l mirror_location/working-dir/cluster-resources/
total 24
-rw-r--r--. 1 stack stack  417 Apr  9 21:11 cc-iib-1125611.yaml
-rw-r--r--. 1 stack stack  448 Apr  9 21:11 cc-redhat-operator-index-v4-18.yaml
-rw-r--r--. 1 stack stack  421 Apr 10 06:54 cs-iib-1125611.yaml
-rw-r--r--. 1 stack stack  436 Apr 10 13:34 cs-redhat-operator-index-v4-18.yaml
-rw-r--r--. 1 stack stack 1909 Apr  9 21:11 idms-oc-mirror.yaml
-rw-r--r--. 1 stack stack 1091 Apr  9 21:11 itms-oc-mirror.yaml

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the example in oc_mirror_catalog_url section the openshift-cert-manager-operator line should be removed?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, i think it should probably be removed. I didn't notice that when I teseted it though, and it seemed to be ok. let's try removing it though and see what happens.


- name: Prepare catalog source for environment
ansible.builtin.shell: |
sed -i 's/cs-{{ index_image_name_tag | quote }}/redhat-operators/g' {{ mirror_location }}/working-dir/cluster-resources/cs-{{ index_image_name_tag }}.yaml
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you only want this to apply to cs-redhat-operator-index-v4-18.yaml

cifmw will create it's own CatalogSource called openstack-operator-index that will be configured to use cifmw_ci_gen_kustomize_values_ooi_image, and then the mirror configuration will make sure the mirror gets used.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this will only apply to: cs-redhat-operator-index-v4-18.yaml. The previous set fact statement uses variable: oc_mirror_cert_manager_catalog_url to extract: redhat-operator-index-v4-18. I could hardcode the file name, but think this gives a little more flexibility.

@softwarefactory-project-zuul
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/68ec32cda5c9495bb05bbd86f98bb58d

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 17m 30s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 23m 52s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 29m 00s
✔️ cifmw-crc-podified-edpm-baremetal-minor-update SUCCESS in 2h 03m 13s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 56s
cifmw-pod-pre-commit FAILURE in 8m 16s

@softwarefactory-project-zuul
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/3baa9443fe84436d94eb8f62bc6e270b

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 21m 04s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 25m 53s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 31m 59s
✔️ cifmw-crc-podified-edpm-baremetal-minor-update SUCCESS in 2h 07m 29s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 10m 41s
cifmw-pod-pre-commit FAILURE in 9m 43s

@softwarefactory-project-zuul
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/b7f6831c3a38441e8b31d359cb133524

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 26m 40s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 32m 06s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 30m 30s
✔️ cifmw-crc-podified-edpm-baremetal-minor-update SUCCESS in 2h 02m 14s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 9m 34s
cifmw-pod-pre-commit FAILURE in 8m 11s

@softwarefactory-project-zuul
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/749f1d93ae1948dc838dbe448b531af2

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 15m 20s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 24m 12s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 29m 53s
✔️ cifmw-crc-podified-edpm-baremetal-minor-update SUCCESS in 2h 02m 58s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 45s
cifmw-pod-pre-commit FAILURE in 10m 03s

@softwarefactory-project-zuul
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/79903bc23f894b8b8233fa0880a098ee

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 16m 06s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 27m 24s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 28m 28s
✔️ cifmw-crc-podified-edpm-baremetal-minor-update SUCCESS in 2h 03m 08s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 9m 42s
cifmw-pod-pre-commit FAILURE in 10m 39s

@softwarefactory-project-zuul
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d3c2d308a96844728a4c40a91fe44dbe

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 19m 03s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 22m 10s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 28m 19s
✔️ cifmw-crc-podified-edpm-baremetal-minor-update SUCCESS in 2h 05m 41s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 28s
cifmw-pod-pre-commit FAILURE in 8m 22s

@softwarefactory-project-zuul
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/fa733e9d790e41f1b516d2829414f210

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 06m 55s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 22m 47s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 33m 48s
✔️ cifmw-crc-podified-edpm-baremetal-minor-update SUCCESS in 1h 53m 49s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 9m 06s
cifmw-pod-pre-commit FAILURE in 8m 15s

@softwarefactory-project-zuul
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/6c682e2aa4c346d1a5abb87786fcb26a

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 20m 44s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 23m 30s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 33m 42s
✔️ cifmw-crc-podified-edpm-baremetal-minor-update SUCCESS in 2h 07m 53s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 9m 04s
cifmw-pod-pre-commit FAILURE in 5m 10s

@TristanCacqueray
Copy link
Copy Markdown
Contributor

recheck

@centosinfra-prod-github-app
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdo/buildset/31d9170de91241159fc81002c14630eb

✔️ openstack-k8s-operators-content-provider SUCCESS in 13m 32s
podified-multinode-edpm-deployment-crc RETRY_LIMIT in 29s
cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 29s
cifmw-crc-podified-edpm-baremetal-minor-update RETRY_LIMIT in 29s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 41s
cifmw-pod-pre-commit FAILURE in 7m 51s

@centosinfra-prod-github-app
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdo/buildset/43c7c605d9314c4dbf5c81c82fec5cd5

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 40m 33s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 27m 33s
cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 34s
cifmw-crc-podified-edpm-baremetal-minor-update RETRY_LIMIT in 32s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 9m 54s
cifmw-pod-pre-commit FAILURE in 9m 11s

@centosinfra-prod-github-app
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdo/buildset/68deedc52fa24b2caebcc55fa40bf337

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 09m 14s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 21m 22s
cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 30s
cifmw-crc-podified-edpm-baremetal-minor-update RETRY_LIMIT in 31s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 9m 12s
cifmw-pod-pre-commit FAILURE in 8m 44s

Create a hook to configure openshift cluster for disconnected
deployment. The hook should execute after the cluster is deployed
but before openstack is deployed.

Signed-off-by: David Rosenfeld drosenfe@redhat.com
@drosenfe drosenfe force-pushed the disconnectedhook branch from 10b7ce2 to e98e925 Compare May 1, 2026 13:11
@centosinfra-prod-github-app
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdo/buildset/3efef40721c44bcdbc3a5ba55013300e

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 36m 33s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 23m 45s
cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 27s
cifmw-crc-podified-edpm-baremetal-minor-update RETRY_LIMIT in 27s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 9m 34s
cifmw-pod-pre-commit FAILURE in 8m 46s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants