[os_must_gather] Add exit rc to os-must-gather main task#3857
[os_must_gather] Add exit rc to os-must-gather main task#3857evallesp wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Reopened from: #3643 |
evallesp
force-pushed
the
os-must-gather-add-return-error
branch
from
7c7d077 to
e50df31
Compare
|
Not tested yet timeout behaviour. |
evallesp
force-pushed
the
os-must-gather-add-return-error
branch
from
e50df31 to
4d97eee
Compare
evallesp
force-pushed
the
os-must-gather-add-return-error
branch
from
4d97eee to
0bc37ce
Compare
evallesp
force-pushed
the
os-must-gather-add-return-error
branch
from
0bc37ce to
d55a7be
Compare
|
Log information at: https://redhat.atlassian.net/browse/OSPCIFMW-95 |
evallesp
force-pushed
the
os-must-gather-add-return-error
branch
from
d55a7be to
16dee34
Compare
evallesp
force-pushed
the
os-must-gather-add-return-error
branch
from
16dee34 to
ecd37f5
Compare
With this we allow to run the rescue block. Previously any timeout in the main task would return the code from the echo which was always success. Also, we're removing from the rescue block the always block. And we've create a always section for finding existing os-must-gather directories and the symlink creation. Also we've changed the dest-dir for the generic fallback command to match the same folder of the symlink. Removed oc inspect as we're not getting so many errors from oc adm must-gather so probably this wouldn't be usefull. Finally, we've parametriced SOS_EDPM as cifmw_os_must_gather_sos_edpm and we've added default value to "all" Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Enrique Vallespi Gil <evallesp@redhat.com>
evallesp
force-pushed
the
os-must-gather-add-return-error
branch
from
ecd37f5 to
2791232
Compare
|
recheck |
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 14m 21s |
|
recheck |
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 42m 45s |
2 participants
With this we allow to run the rescue block. Previously any timeout
in the main task would return the code from the echo which was
always success.
Also, we're removing from the rescue block the always block.
And we've create a always section for finding existing os-must-gather
directories and the symlink creation.
Also we've changed the dest-dir for the generic fallback command
to match the same folder of the symlink.
Removed oc inspect as we're not getting so many errors from oc adm must-gather
so probably this wouldn't be usefull.
Finally, we've parametriced SOS_EDPM as cifmw_os_must_gather_sos_edpm
and we've added default value to "all"
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com
Signed-off-by: Enrique Vallespi Gil evallesp@redhat.com