Fix namespace stuck on cleanup by separating deletion phases#3866
Open
mnietoji wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
Open
Fix namespace stuck on cleanup by separating deletion phases#3866mnietoji wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
mnietoji wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
mnietoji
force-pushed
the
clean_openstack
branch
from
88c7526 to
59c7e9f
Compare
mnietoji
force-pushed
the
clean_openstack
branch
from
59c7e9f to
59636b7
Compare
evallesp
reviewed
Apr 27, 2026
| }} | ||
| ansible.builtin.import_tasks: cleanup_crs.yaml | ||
|
|
||
| - name: Delete deployment CRs (Phase 2 - Operators) |
Contributor
There was a problem hiding this comment.
(non-blocking) suggestion: Might be a good addition checking if previous phase has ended before running phase 2 ?
mnietoji
force-pushed
the
clean_openstack
branch
from
59636b7 to
54d0765
Compare
…tion phases Split CRs deletion into two phases to prevent namespace getting stuck during cleanup: - Phase 1: Delete application resources (DataPlane, ControlPlane, BMH, etc.) - Phase 2: Delete operators (NMState, MetalLB, OpenStack operators, OLM) - Wait between phases to ensure Phase 1 resources are fully deleted This prevents race condition where operator controller is deleted before it can process finalizers from application resources, which causes the namespace to hang indefinitely. Fixes: Namespace stuck when RabbitmqCluster finalizer cannot be processed Signed-off-by: Miguel Angel Nieto Jimenez <mnietoji@redhat.com> Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
mnietoji
force-pushed
the
clean_openstack
branch
from
54d0765 to
a2966f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: OpenstackVersion stuck with finalizer when namespace is being deleted