[devscripts] Preserve host-passthrough CPU in metal3 devscripts#3896
Open
danpawlik wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
Open
[devscripts] Preserve host-passthrough CPU in metal3 devscripts#3896danpawlik wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
danpawlik wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
Conversation
The metal3 generates a file in work dir:
# metal3-dev-env/vm-setup/roles/libvirt/tasks/vm_setup_tasks.yml
(...)
- name: Detect virtualization if libvirt_domain_type is not provided
command: systemd-detect-virt
ignore_errors: true
become: true
register: virt_result
- name: Default to qemu if inside a VM
set_fact:
libvirt_domain_type: qemu
when: virt_result is succeeded
- name: Default to kvm if a VM is not detected
set_fact:
libvirt_domain_type: kvm
when: virt_result is failed
when: libvirt_domain_type is undefined
which generates later in an SNO VM xml:
<cpu mode='custom' match='exact' check='full'>
<model fallback='forbid'>EPYC</model>
<vendor>AMD</vendor>
<feature policy='require' name='monitor'/>
<feature policy='require' name='x2apic'/>
<feature policy='require' name='hypervisor'/>
<feature policy='require' name='acpi'/>
<feature policy='require' name='ss'/>
<feature policy='require' name='erms'/>
<feature policy='require' name='mpx'/>
<feature policy='require' name='clwb'/>
<feature policy='require' name='umip'/>
<feature policy='require' name='pku'/>
<feature policy='require' name='vaes'/>
<feature policy='require' name='la57'/>
<feature policy='require' name='rdpid'/>
<feature policy='require' name='pks'/>
<feature policy='require' name='fsrm'/>
<feature policy='require' name='cmpccxadd'/>
<feature policy='require' name='fzrm'/>
<feature policy='require' name='fsrs'/>
<feature policy='require' name='fsrc'/>
<feature policy='require' name='3dnowext'/>
<feature policy='require' name='3dnow'/>
<feature policy='require' name='xsaveerptr'/>
<feature policy='require' name='wbnoinvd'/>
<feature policy='require' name='npt'/>
<feature policy='require' name='vgif'/>
<feature policy='require' name='svme-addr-chk'/>
<feature policy='require' name='no-nested-data-bp'/>
<feature policy='require' name='null-sel-clr-base'/>
<feature policy='disable' name='vme'/>
<feature policy='disable' name='xsavec'/>
<feature policy='disable' name='misalignsse'/>
<feature policy='disable' name='osvw'/>
<feature policy='disable' name='topoext'/>
<feature policy='disable' name='fxsr_opt'/>
<feature policy='disable' name='nrip-save'/>
</cpu>
instead of host-passthrough. Bypass that behavior and always use
host-passthrough.
Signed-off-by: Daniel Pawlik <dpawlik@redhat.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The metal3 generates a file in work dir:
which generates later in an SNO VM xml:
instead of host-passthrough. Bypass that behavior and always use
host-passthrough.