[ci] Extend the kustomizations in logging to include autoscaling#698
Conversation
|
Skipping CI for Draft Pull Request. |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/042d960c21a84c91acc94128427bb99c ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 06m 50s |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/28cc86da59b242c5936f9a5507c11ac4 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 06m 12s |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/9775b64aa6104ba385f4468b3f65e30f ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 33m 43s |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/5a26ce276d9e4ee98140ffa1969fdeff ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 35m 33s |
elfiesmelfie
force-pushed
the
ci/combine-autoscaling-logging
branch
from
b6a3637 to
3b8b9e8
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/8835779a32804aff91c755133eedfb63 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 37m 03s |
elfiesmelfie
force-pushed
the
ci/combine-autoscaling-logging
branch
from
3b8b9e8 to
cc08eb9
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/c1922ffed02541698bb511a2197edcf5 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 02m 31s |
elfiesmelfie
force-pushed
the
ci/combine-autoscaling-logging
branch
from
cc08eb9 to
8cebceb
Compare
vyzigold
left a comment
vyzigold
left a comment
There was a problem hiding this comment.
As written in the PR description, I also think we should be creating the kustomization files, so this is going in the right direction, we just need to fix the issue with default-telemetry.
| - name: Import tasks for creating COO subscription | ||
| ansible.builtin.include_tasks: "create-coo-subscription.yaml" | ||
|
|
||
| - name: Copy controlplane kustomization |
There was a problem hiding this comment.
This destroys the default-telemetry scenario, which relies on enabling / disabling parts of telemetry on its own as it goes
There was a problem hiding this comment.
Also it'd be good to rename the file if it's doing more than just creating the COO sub.
There was a problem hiding this comment.
I see I'm incorrect, the default-telemetry works, because it actually doesn't check the environment it starts with. But I still think we shouldn't apply the kustomization for that job. One of the first steps in default-telemetry are:
- Start without autoscaling and metricstorage enabled
- Check that telemetry-operator works
- Enable autoscaling and metricstorage
- Check that everything went smooth and no errors are logged in telemetry-operator.
There was a problem hiding this comment.
I'll have a closer look at this, but I think it might be fixed with #700, which replaces the playbook with a var that triggers the installation in cifmw
There was a problem hiding this comment.
I left a comment on #700 . I think once that merges, then we could merge this one as well.
elfiesmelfie
force-pushed
the
ci/combine-autoscaling-logging
branch
from
8cebceb to
b910c0d
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f3f6f6bef18b4b13a9c9a4217485cb5e ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 20m 55s |
elfiesmelfie
force-pushed
the
ci/combine-autoscaling-logging
branch
2 times, most recently
from
ba682bb to
707637a
Compare
The cifmw_edpm_prepare_kustomizations var defined in vars-autoscaling gets replaced by the one in logging. This means that autoscaling doesn't get enabled. This change moves the kustomzations into files that get applied during deployment. This is the same method that is used by the loggin dataplane configuration. * The logging and autoscaling kustomizations have been moved into the pre_deploy hooks, which copy the kustomizations to the appropriate file location. * The autoscaling kustomization is done in a newly-defined hook. * The dashboard dashboard enablement kustomization is separated out of the autoscaling
elfiesmelfie
force-pushed
the
ci/combine-autoscaling-logging
branch
from
707637a to
4ba8301
Compare
|
/test telemetry-operator-build-deploy |
|
/test telemetry-operator-build-deploy-kuttl |
|
recheck |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elfiesmelfie, vyzigold The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
Bot
merged commit 3ba8662
into
openstack-k8s-operators:main
2 participants
The cifmw_edpm_prepare_kustomizations var defined in vars-autoscaling gets replaced by the one in logging. This means that autoscaling doesn't get enabled when both are deployed together.
For now, I have copied the various kustomizations into the same var in the logging file.
Going forward, this should be updated to copy the kustomizations into the artifacts/manifests/kustomizations/controlplane dir in separate hooks, so that they can be enabled/disabled independantly.
This is related to infrawatch/feature-verification-tests#273
Depends-On: openstack-k8s-operators/ci-framework#3063
Depends-On: #700