Skip to content

Enable NFS server as cinder backend for master job#217

Merged
openshift-merge-bot[bot] merged 1 commit intoopenstack-k8s-operators:mainfrom
cescgina:enabled_nfs_server_cinder_backend
Oct 8, 2025
Merged

Enable NFS server as cinder backend for master job#217
openshift-merge-bot[bot] merged 1 commit intoopenstack-k8s-operators:mainfrom
cescgina:enabled_nfs_server_cinder_backend

Conversation

@cescgina
Copy link
Copy Markdown
Contributor

@cescgina cescgina commented Jul 11, 2025

Deploy an NFS server in a compute node using cifmw and use it as backend
for cinder. This is needed to test volume migrations and depending on
the result we might enable it in all jobs or only in some.

Depends-On: https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/958644
Depends-On: #275

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jul 11, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@cescgina cescgina force-pushed the enabled_nfs_server_cinder_backend branch 2 times, most recently from 682e745 to b7d92c0 Compare July 14, 2025 10:08
@softwarefactory-project-zuul
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/bd9c1aeda2594bf1815245993de81b20

✔️ openstack-meta-content-provider-master SUCCESS in 1h 49m 04s
watcher-operator-validation-master FAILURE in 1h 01m 17s (non-voting)
✔️ openstack-meta-content-provider-epoxy SUCCESS in 1h 24m 18s
watcher-operator-validation-epoxy FAILURE in 59m 34s
watcher-operator-validation-epoxy-ocp4-16 FAILURE in 59m 56s
✔️ noop SUCCESS in 0s
✔️ watcher-operator-kuttl SUCCESS in 37m 51s

@cescgina cescgina force-pushed the enabled_nfs_server_cinder_backend branch 5 times, most recently from bdf51c1 to ea2e41d Compare July 15, 2025 09:58
@softwarefactory-project-zuul
Copy link
Copy Markdown

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.

@cescgina
Copy link
Copy Markdown
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link
Copy Markdown

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.

@cescgina
Copy link
Copy Markdown
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d3f2b4ca962c4c578b6ac9f8c360a33a

✔️ openstack-meta-content-provider-master SUCCESS in 3h 04m 18s
watcher-operator-validation-master FAILURE in 2h 08m 24s (non-voting)
✔️ openstack-meta-content-provider-epoxy SUCCESS in 2h 18m 30s
watcher-operator-validation-epoxy FAILURE in 1h 01m 49s
✔️ watcher-operator-validation-epoxy-ocp4-16 SUCCESS in 1h 47m 40s
✔️ noop SUCCESS in 0s
✔️ watcher-operator-kuttl SUCCESS in 36m 56s

@cescgina
Copy link
Copy Markdown
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/95c2626580bf4e97a1b8bfe64df99a3d

✔️ openstack-meta-content-provider-master SUCCESS in 3h 05m 13s
✔️ watcher-operator-validation-master SUCCESS in 2h 10m 55s (non-voting)
✔️ openstack-meta-content-provider-epoxy SUCCESS in 2h 19m 46s
watcher-operator-validation-epoxy FAILURE in 1h 01m 11s
✔️ watcher-operator-validation-epoxy-ocp4-16 SUCCESS in 1h 49m 27s
✔️ noop SUCCESS in 0s
✔️ watcher-operator-kuttl SUCCESS in 36m 51s

@cescgina cescgina force-pushed the enabled_nfs_server_cinder_backend branch from ea2e41d to dae6c8e Compare July 16, 2025 14:34
@softwarefactory-project-zuul
Copy link
Copy Markdown

This change depends on a change that failed to merge.

Change #221 is needed.

@cescgina
Copy link
Copy Markdown
Contributor Author

recheck

1 similar comment
@cescgina
Copy link
Copy Markdown
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link
Copy Markdown

This change depends on a change that failed to merge.

Change https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/954625 is needed.

@cescgina
Copy link
Copy Markdown
Contributor Author

recheck

1 similar comment
@cescgina
Copy link
Copy Markdown
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link
Copy Markdown

This change depends on a change that failed to merge.

Change https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/954625 is needed.

@cescgina
Copy link
Copy Markdown
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link
Copy Markdown

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/watcher-operator for 217,dae6c8ec35772262202e1226c272ffb06d4ade14

@cescgina cescgina force-pushed the enabled_nfs_server_cinder_backend branch from dae6c8e to d4d8e71 Compare August 19, 2025 13:09
@softwarefactory-project-zuul
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/190b710637624608b30efd6dadb19fb8

✔️ openstack-meta-content-provider-master SUCCESS in 2h 51m 09s
✔️ watcher-operator-validation-master SUCCESS in 1h 59m 42s (non-voting)
✔️ openstack-meta-content-provider-epoxy SUCCESS in 2h 30m 55s
✔️ watcher-operator-validation-epoxy SUCCESS in 2h 00m 27s
✔️ watcher-operator-validation-epoxy-ocp4-16 SUCCESS in 2h 07m 57s
✔️ noop SUCCESS in 0s
watcher-operator-kuttl FAILURE in 1h 10m 17s

@cescgina
Copy link
Copy Markdown
Contributor Author

recheck

1 similar comment
@cescgina
Copy link
Copy Markdown
Contributor Author

recheck

@cescgina cescgina force-pushed the enabled_nfs_server_cinder_backend branch from 6ed0471 to 12fd3bd Compare September 30, 2025 10:37
@softwarefactory-project-zuul
Copy link
Copy Markdown

This change depends on a change that failed to merge.

Change #275 is needed.

@cescgina
Copy link
Copy Markdown
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ce47d1cd1de24599b61b71d36e5c472e

✔️ openstack-meta-content-provider-master SUCCESS in 4h 27m 05s
✔️ watcher-operator-validation-master SUCCESS in 2h 05m 23s (non-voting)
✔️ openstack-meta-content-provider-epoxy SUCCESS in 2h 19m 05s
✔️ watcher-operator-validation-epoxy SUCCESS in 1h 55m 47s
watcher-operator-validation-epoxy-ocp4-16 FAILURE in 21m 27s
✔️ noop SUCCESS in 0s
✔️ watcher-operator-kuttl SUCCESS in 41m 55s

@cescgina
Copy link
Copy Markdown
Contributor Author

cescgina commented Oct 1, 2025

volume migration tests are passing with the nfs configuration:

watcher_tempest_plugin.tests.scenario.test_execute_zone_migration.TestExecuteZoneMigrationStrategyVolume 	2 	2 	0 	0 	0
test_execute_zone_migration_volume_migrate[id-2287000d-6f0e-4275-8741-cfeb38090307,strategy,volume_migration,zone_migration]
	pass
test_execute_zone_migration_volume_retype[id-f8f4d551-d892-4111-ab92-5b6b5523e5dc,strategy,volume_migration,zone_migration]
	pass

from https://logserver.rdoproject.org/58c/rdoproject.org/58c025cd54da4399951a92a855c49205/controller/ci-framework-data/tests/test_operator/tempest-tests-tempest/tempest_results.html

@cescgina cescgina marked this pull request as ready for review October 1, 2025 07:29
@openshift-ci openshift-ci Bot requested review from amoralej and stuggi October 1, 2025 07:29
@cescgina
Copy link
Copy Markdown
Contributor Author

cescgina commented Oct 1, 2025

recheck

@cescgina cescgina changed the title [WIP] Enabled NFS server as cinder backend Enable NFS server as cinder backend for master job Oct 1, 2025
nas_secure_file_operations=false
nas_secure_file_permissions=false
customServiceConfigSecrets:
- cinder-volume-nfs-secrets
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this all looks fine until here

normally if you have 2 nfs poosl they woudl not use the same storage

you have both of them refencing the same secret
which looks liek this
cinder-volume-nfs-secrets: |
[nfs]
nas_host={{ cifmw_nfs_ip }}
nas_share_path={{ '/data/' + cifmw_nfs_shares[0] }}

we woudl ideally have one secree per nfs backend so that they are actully using diffnt strage lcoations on the backing nfs server or on seperate nfs servers.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, I was meant to do this but I forgot. I've updated the PR adding the additional share and creating separate secrets, one per pool

Comment thread ci/scenarios/nfs.yml
Comment thread ci/scenarios/nfs.yml
@cescgina cescgina force-pushed the enabled_nfs_server_cinder_backend branch 2 times, most recently from 3ef0058 to 099a3cd Compare October 2, 2025 17:14
@softwarefactory-project-zuul
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/631d1bcb0eab4bc296de60d773e7ae09

✔️ openstack-meta-content-provider-master SUCCESS in 2h 57m 04s
✔️ watcher-operator-validation-master SUCCESS in 2h 06m 45s (non-voting)
✔️ openstack-meta-content-provider-epoxy SUCCESS in 2h 26m 22s
✔️ watcher-operator-validation-epoxy SUCCESS in 2h 02m 56s
watcher-operator-validation-epoxy-ocp4-16 FAILURE in 20m 36s
✔️ noop SUCCESS in 0s
✔️ watcher-operator-kuttl SUCCESS in 44m 31s

Deploy an NFS server in a compute node using cifmw and use it as backend
for cinder. This is needed to test volume migrations and depending on
the result we might enable it in all jobs or only in some.
@cescgina cescgina force-pushed the enabled_nfs_server_cinder_backend branch from 099a3cd to 45d3689 Compare October 3, 2025 07:42
@cescgina cescgina requested a review from SeanMooney October 3, 2025 07:42
Copy link
Copy Markdown
Collaborator

@SeanMooney SeanMooney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok ya this version looks good to me
thanks for updating it

Comment thread ci/playbooks/templates/cinder-volume-nfs-secrets.yaml.j2

- name: Create the definition of the secrets
vars:
share: "{{ cifmw_nfs_shares[indx] }}"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah its set here.

@amoralej
Copy link
Copy Markdown
Contributor

amoralej commented Oct 8, 2025

/approve

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Oct 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amoralej

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved label Oct 8, 2025
@openshift-merge-bot openshift-merge-bot Bot merged commit 9c9ab71 into openstack-k8s-operators:main Oct 8, 2025
6 checks passed
@cescgina cescgina deleted the enabled_nfs_server_cinder_backend branch October 8, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants