Merged
Conversation
basfroman
reviewed
May 6, 2025
Contributor
basfroman
left a comment
There was a problem hiding this comment.
we shouldn't release it without minimum tests coverage of retry behavior
Collaborator
Author
Yeah. Testing it (in an automated, repeatable way) is difficult. Will work on it. |
Contributor
I think a simple e2e test will be enough for a start:
|
basfroman
reviewed
May 6, 2025
basfroman
reviewed
May 7, 2025
basfroman
approved these changes
May 7, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds subclasses of SubstrateInterface and AsyncSubstrateInterface that allow for handling chain failures by using backup chains. If a sustained network failure is encountered on a chain endpoint, the object will initialize a new connection on the next chain in the
fallback_chainslist. If theretry_foreverflag is set, upon reaching the last chain infallback_chains, the connection will attempt to iterate over the list (starting withurl) again.E.g.
In this case, if there is a failure on entrypoint-finney, the connection will next attempt to hit localhost. If this
also fails, a
MaxRetriesExceededexception will be raised.In this case, rather than a MaxRetriesExceeded exception being raised upon failure of the second chain (localhost), the object will again being to initialize a new connection on entrypoint-finney, and then localhost, and so on and so forth.