Merged
Conversation
Closed
|
|
||
|
|
||
| def _create_table(c, conn, table_name): | ||
| c.execute( |
Contributor
There was a problem hiding this comment.
we can simply use Connection ctx manager:
with conn:
conn.execute
Collaborator
Author
There was a problem hiding this comment.
I think this isn't available on 3.9, but can double-check.
Collaborator
Author
There was a problem hiding this comment.
Actually, it is available, but do we want to do that rather than just reuse the same cursor object repeatedly?
|
|
||
| def _insert_into_cache(c, conn, table_name, key, result, chain): | ||
| try: | ||
| c.execute( |
Contributor
There was a problem hiding this comment.
connection context manager?
| chain = self.url | ||
| if not (local_chain := _check_if_local(chain)) or not USE_CACHE: | ||
| result = _retrieve_from_cache(c, table_name, key, chain) | ||
| if result is not None: |
Contributor
There was a problem hiding this comment.
is it possible to cache None value?
Collaborator
Author
There was a problem hiding this comment.
is it possible to cache
Nonevalue?
Yes. But none of the cached methods can ever return None.
…tead only use it in an experimental new class for just async substrate.
basfroman
approved these changes
Mar 11, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caches commonly used functions on-disk