Removing GitHub workflow push docker#1011
Merged
Conversation
Contributor
eduardogr
commented
Nov 24, 2022
eduardogr
commented
- Removing github workflow for pushing docker image
camfairchild
approved these changes
Nov 25, 2022
Contributor
camfairchild
left a comment
camfairchild
left a comment
There was a problem hiding this comment.
I agree. Should be on circleCI instead
eduardogr
force-pushed
the
sre/removing-github-workflow-push-docker
branch
2 times, most recently
from
13f46bc to
eaca923
Compare
Eugene-hu
approved these changes
Dec 6, 2022
Contributor
Eugene-hu
left a comment
Eugene-hu
left a comment
There was a problem hiding this comment.
Yea, I agree. I think this consistently fails on github actions. Do we need another script to push to docker or is that depreciated?
Contributor
Author
Great! 🚀 |
eduardogr
force-pushed
the
sre/removing-github-workflow-push-docker
branch
from
eaca923 to
b426a85
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.