Skip to content

Fix Val logging #1078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
camfairchild wants to merge 3 commits into from
Closed

Fix Val logging #1078

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2942f0a
call method with netuid
camfairchild Jan 28, 2023
57b4628
typo
camfairchild Jan 28, 2023
837763b
check numel first
camfairchild Jan 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions bittensor/_neuron/text/core_validator/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,8 +513,8 @@ def run_epoch( self ):
# console table - weight table (every validation step)
sample_uids, sample_weights = self.calculate_weights()
self.vlogger.print_weights_table(
min_allowed_weights = self.subtensor.min_allowed_weights,
max_weight_limit = self.subtensor.max_weight_limit,
min_allowed_weights = self.subtensor.min_allowed_weights( netuid = self.config.netuid ),
max_weight_limit = self.subtensor.max_weight_limit( netuid = self.config.netuid ),
neuron_stats = self.neuron_stats,
title = str(self),
metagraph_n = self.metagraph.n,
Expand Down Expand Up @@ -559,8 +559,8 @@ def run_epoch( self ):
if self.config.logging.debug or self.config.logging.trace:
# console table - weight table (every end of epoch)
self.vlogger.print_weights_table(
min_allowed_weights = self.subtensor.min_allowed_weights,
max_weight_limit = self.subtensor.max_weight_limit,
min_allowed_weights = self.subtensor.min_allowed_weights( netuid = self.config.netuid ),
max_weight_limit = self.subtensor.max_weight_limit( netuid = self.config.netuid ),
neuron_stats = self.neuron_stats,
title = str(self),
metagraph_n = self.metagraph.n,
Expand Down
11 changes: 9 additions & 2 deletions bittensor/_neuron/text/log_utilities.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,13 +331,20 @@ def print_weights_table(
_neuron_stats = {uid: stats for uid, stats in _neuron_stats.items() if uid in limited_uids}

print()
max_str: str = 'NA'
min_str: str = 'NA'
if sample_weights.numel() != 0:
# Has weights to print
max_str = f'{sample_weights.max().item():.4g}'
min_str = f'{sample_weights.min().item():.4g}'

self.print_stats_table(_neuron_stats, 'weight',
f'[white] Neuron weights [/white] | ' + title, # title
f'Validated {min_allowed_weights}/'
f'[bold]{len(neuron_stats)}[/bold]/{metagraph_n} (min/[bold]valid[/bold]/total) | '
f'sum:{sample_weights.sum().item():.2g} '
f'[white] max:[bold]{sample_weights.max().item():.4g}[/bold] / '
f'min:[bold]{sample_weights.min().item():.4g}[/bold] [/white] '
f'[white] max:[bold]{max_str}[/bold] / '
f'min:[bold]{min_str}[/bold] [/white] '
f'\[{max_weight_limit:.4g} allowed]', # caption
mark_uids=include_uids)

Expand Down