Fix axon requests signature using metadata#1394
Merged
Conversation
Contributor
Author
|
Honours goes to Adrianmares for the majority of this fix. |
adriansmares
approved these changes
Jun 17, 2023
ifrit98
reviewed
Jun 17, 2023
Contributor
ifrit98
left a comment
ifrit98
left a comment
There was a problem hiding this comment.
Nice! This looks good to me.
Should we also update the int version also in the Auth Interceptor to 510?
bittensor/bittensor/_axon/__init__.py
Line 308 in 8e3f932
Contributor
Author
|
Well throw that in a different PR @ifrit98 |
ifrit98
approved these changes
Jun 17, 2023
shibshib
approved these changes
Jun 19, 2023
camfairchild
approved these changes
Jun 20, 2023
Merged
ifrit98
reviewed
Jun 21, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix checks signature of requester during every call to text_prompting forward synapse using the signature generated on GRPC TCP channel creation.
This removes the possibility for man in the middle attacks where a malicious actor is capable of spoofing the keys of network validators.