fixes tensors not hashing correctly#1545
Closed
CreativeBuilds wants to merge 2 commits intoopentensor:stagingfrom
Closed
fixes tensors not hashing correctly#1545CreativeBuilds wants to merge 2 commits intoopentensor:stagingfrom
CreativeBuilds wants to merge 2 commits intoopentensor:stagingfrom
Conversation
Eugene-hu
reviewed
Oct 16, 2023
| # Getting the fields of the instance | ||
| instance_fields = self.__dict__ | ||
|
|
||
| instance_fields = self.dict() # __dict__ converts the Tensor types into strings causing a mismatch in the hash, so we use .dict() instead |
Contributor
There was a problem hiding this comment.
I think @ifrit98 would have better visibility on this change than I do, so we should for his approval before merging.
Contributor
There was a problem hiding this comment.
@ifrit98 would this create an issue for the header size? If I am not mistaken, there is a sizing limit on the headers which caused us to create hashes rather than using the full tensor.
Contributor
|
See: #1548 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue was caused from using
__dict__which converted the Tensor object into one with just its datatype and shape values, disregarding the actual buffer or content within the Tensor.The Axon.py file when it was trying to decode the response from the sender would then compare the hash using the buffer that was sent, causing a mismatch of hashes.
This change fixes that by utilizing
.dict()instead.