Skip to content

Remove tensor headers#1554

Closed
ifrit98 wants to merge 3 commits intostagingfrom
rm-tensor-headers
Closed

Remove tensor headers#1554
ifrit98 wants to merge 3 commits intostagingfrom
rm-tensor-headers

Conversation

@ifrit98
Copy link
Contributor

@ifrit98 ifrit98 commented Oct 20, 2023

  • This ensures that headers don't exceed 8kb limit for http protocol.
  • Removes all tensor related header information in to_headers() and from_headers()

@ifrit98 ifrit98 requested review from Eugene-hu, p-ferreira and unconst and removed request for unconst October 20, 2023 17:44
@ifrit98 ifrit98 mentioned this pull request Oct 21, 2023
Merged
@ifrit98
Copy link
Contributor Author

ifrit98 commented Oct 21, 2023

See #1555. Included there.

@ifrit98 ifrit98 closed this Oct 21, 2023
@CreativeBuilds
Copy link
Contributor

CreativeBuilds commented Oct 23, 2023

Does this mean that tensors are no longer being hashed/secured over transit?

@ifrit98
Copy link
Contributor Author

ifrit98 commented Oct 23, 2023

Does this mean that tensors are no longer being hashed/secured over transit?

No, any field set in required_hash_fields in the subnet protocol will still be verified, regardless of object type. This is specifically referring to metadata about tensor objects, and doesn't have to do with their verification.

@ifrit98 ifrit98 deleted the rm-tensor-headers branch December 14, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Eugene-hu Eugene-hu Awaiting requested review from Eugene-hu

@unconst unconst Awaiting requested review from unconst

@p-ferreira p-ferreira Awaiting requested review from p-ferreira

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ifrit98 @CreativeBuilds